Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer ignores PSS #86

Open
avivklas opened this issue Sep 1, 2020 · 2 comments
Open

Signer ignores PSS #86

avivklas opened this issue Sep 1, 2020 · 2 comments
Labels
certstore

Comments

@avivklas
Copy link

avivklas commented Sep 1, 2020

On both windows and darwin, using the Signer of an Identity object as a private key of a TLS certificate doesn't work against a server that requires TLS v1.3.
In this case, a GO TLS server, for example, returns an "error decrypting message" error due to missing 0xbc at the end of the signature during the handshake. The reason for this is not using the padding scheme when signing the digest.
@avivklas
Copy link
Author

avivklas commented Sep 1, 2020

I already have a working fix and I'm about to issue a PR soon

avivklas referenced this issue in cyolosecurity/certstore Sep 1, 2020
#17 fix wrong PSS RSA handling
e158315
@tg123
Copy link

tg123 commented Nov 15, 2020

link github/certstore#20, I fixed PSS when remove cgo as well

avivklas referenced this issue in cyolosecurity/certstore Jan 20, 2021
#17 made signing in darwin use PSS only for rsa
38ac2d3
avivklas referenced this issue in cyolosecurity/certstore Jan 20, 2021
#17 code improvements
9170544
avivklas referenced this issue in cyolosecurity/certstore Jan 20, 2021
#17 fixed missing cast for windows
824f68a
avivklas referenced this issue in cyolosecurity/certstore Jan 20, 2021
#17 removed unused import
721977d
avivklas referenced this issue in cyolosecurity/certstore Jan 20, 2021
#17 fixed error string building in windows
20503ac
avivklas referenced this issue in cyolosecurity/certstore Aug 31, 2021
#17 better error clarity for irrational capi flow with
f1cc86d
avivklas referenced this issue in cyolosecurity/certstore Aug 31, 2021
#17 added tests with PSS signOpts
f4f96f7
avivklas referenced this issue in cyolosecurity/certstore Sep 2, 2021
#17 better error clarity for irrational capi flow with
260a1e7
avivklas referenced this issue in cyolosecurity/certstore Sep 4, 2021
#17 fixed salt length setting when set to auto in cng-pss flow
f4fa051
@lgarron lgarron transferred this issue from github/certstore Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
certstore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tg123 @lgarron @avivklas