Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoggingEventAsyncDisruptorAppender should flush appenders implementing Flushable at end of a batch #454

Closed
brenuart opened this issue Dec 27, 2020 · 2 comments
Closed

LoggingEventAsyncDisruptorAppender should flush appenders implementing Flushable at end of a batch #454

brenuart opened this issue Dec 27, 2020 · 2 comments
Labels
type/enhancement
Milestone
6.6

Comments

@brenuart
Copy link
Collaborator

brenuart commented Dec 27, 2020 •
edited
Loading

Similar to #346, it would be nice if LoggingEventAsyncDisruptorAppenderalso flushes appenders implementing java.io.Flushable at the end of a batch.

I came across this issue because we have some custom appenders not extending OutputStreamAppender that would benefit from an explicit flush as well... What do you think ?
@philsttr
Copy link
Collaborator

Seems reasonable to me. Would you be willing to submit a PR?

This was referenced Dec 28, 2020
Closed
Merged
@philsttr
Copy link
Collaborator

Closed by #457

@philsttr philsttr added this to the 6.6 milestone Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
6.6
Development

No branches or pull requests
2 participants
@brenuart @philsttr