Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow to redeem gift cards when purchasing other gift cards #7318

Open
AndreiMaz opened this issue Aug 22, 2024 · 1 comment
Open

Comments

@AndreiMaz
Copy link
Member

AndreiMaz commented Aug 22, 2024

nopCommerce version: 4.70.4

Do not allow to redeem gift cards when purchasing other gift cards. So when a customer will try to apply a gift card, we should validate whether it could be used or not. We already have the same logic applied to discounts (do not allow to purchase gift cards) - please check the "ValidateDiscountAsync" method of the "DiscountService":

if (await _productService.HasAnyGiftCardProductAsync(cartProductIds))
{...}

Let's implement the same logic in "GiftCardService.IsGiftCardValidAsync" and "ShoppingCartController.ApplyGiftCard" methods

@AndreiMaz
Copy link
Member Author

AndreiMaz commented Aug 29, 2024

original issue moved to #6681 but let's implement this one as well

@AndreiMaz AndreiMaz closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
@AndreiMaz AndreiMaz removed this from the Version 4.80 milestone Aug 29, 2024
@AndreiMaz AndreiMaz reopened this Aug 29, 2024
@AndreiMaz AndreiMaz added this to the Version 4.80 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants