Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decentralize queries #277

Closed
cjgillot opened this issue Apr 18, 2020 · 3 comments
Closed

Decentralize queries #277

cjgillot opened this issue Apr 18, 2020 · 3 comments
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@cjgillot
Copy link

cjgillot commented Apr 18, 2020 •
edited by pnkfelix
Loading

TL;DR

Allow each compiler crate to define its own queries, instead of declaring everything in librustc_middle.
This would remove the need for datatype definitions in librustc_middle.

Links and Details

Exploratory work: moving the query system out of librustc_middle -> rust-lang/rust#70951

Mentors or Reviewers

I have not looked for people yet.
@eddyb might be interested because of rust-lang/rust#70951 (comment)

Note: Discussion of the proposal should happen on the associated zulip topic (read access available at associated zulip archive). This issue is meant to summarize the high level points and to track status of the proposal.
@cjgillot cjgillot added the major-change A proposal to make a major change to rustc label Apr 18, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 18, 2020
@cjgillot cjgillot mentioned this issue Apr 21, 2020
Merged
@spastorino
Copy link
Member

Added to our compiler team meeting agenda, removing to-announce label.

@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Apr 23, 2020
@nikomatsakis
Copy link
Contributor

@cjgillot heh I can't find the zulip stream ... so I like the idea here but I feel like we're missing some details of how you plan to go about it. It's a big PR -- can you maybe update the description with some details of how you are decentralizing exactly?

@spastorino spastorino added the T-compiler Add this label so rfcbot knows to poll the compiler team label Sep 17, 2020
@jyn514 jyn514 mentioned this issue Sep 21, 2020
Merged
Closed
@cjgillot cjgillot changed the title Decentralize queries Move query implementation out of rustc_middle Nov 18, 2020
@cjgillot cjgillot changed the title Move query implementation out of rustc_middle Decentralize queries Nov 18, 2020
@nikomatsakis
Copy link
Contributor

Closing per @cjgillot's comment on Zulip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spastorino @nikomatsakis @cjgillot @rustbot