Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ui-external url #1970

Merged
merged 6 commits into from
Dec 27, 2023
Merged

fix ui-external url #1970

merged 6 commits into from
Dec 27, 2023

Conversation

qdirks
Copy link
Contributor

@qdirks qdirks commented Jun 12, 2022

When browser-sync is serving files, this is what it prints in the console:

[Browsersync] Access URLs:
 --------------------------------------
       Local: http://localhost:3000
    External: http://192.168.0.242:3000
 --------------------------------------
          UI: http://localhost:3001
 UI External: http://localhost:3001         <-- This is not the external access url
 --------------------------------------
[Browsersync] Serving files from: ./

This pull request changes it to this:

[Browsersync] Access URLs:
 --------------------------------------
       Local: http://localhost:3000
    External: http://192.168.0.242:3000
 --------------------------------------
          UI: http://localhost:3001
 UI External: http://192.168.0.242:3001
 --------------------------------------
[Browsersync] Serving files from: ./

@qdirks qdirks mentioned this pull request Jun 12, 2022
Closed
dippas
dippas approved these changes Jun 21, 2022
View reviewed changes
Copy link

@dippas dippas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cossssmin
Copy link

Any chance we can see this merged in the next patch release? 😇

@shakyShane shakyShane merged commit dc33c0b into BrowserSync:master Dec 27, 2023
@shakyShane
Copy link
Contributor

available in 3.0.2 :)

image

CaffeeLake pushed a commit to MISW/works-misw-jp that referenced this pull request Jun 11, 2024
@renovate
Update dependency browser-sync to v3 (#108)
4a06165 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [browser-sync](https://browsersync.io/)
([source](https://togithub.com/BrowserSync/browser-sync)) | [`2.29.3` ->
`3.0.2`](https://renovatebot.com/diffs/npm/browser-sync/2.29.3/3.0.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/browser-sync/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/browser-sync/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/browser-sync/2.29.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/browser-sync/2.29.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>BrowserSync/browser-sync (browser-sync)</summary>

###
[`v3.0.2`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v3.0.2)

[Compare
Source](https://togithub.com/BrowserSync/browser-sync/compare/v3.0.1...v3.0.2)

#### What's Changed

- fix: dist path by [@&#8203;bufo24](https://togithub.com/bufo24) in
[BrowserSync/browser-sync#2054
- fix ui-external url by [@&#8203;qdirks](https://togithub.com/qdirks)
in
[BrowserSync/browser-sync#1970

#### New Contributors

- [@&#8203;bufo24](https://togithub.com/bufo24) made their first
contribution in
[BrowserSync/browser-sync#2054
- [@&#8203;qdirks](https://togithub.com/qdirks) made their first
contribution in
[BrowserSync/browser-sync#1970

**Full Changelog**:
BrowserSync/browser-sync@v3.0.1...v3.0.2

###
[`v3.0.1`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v3.0.1)

[Compare
Source](https://togithub.com/BrowserSync/browser-sync/compare/v3.0.0...v3.0.1)

#### ⚠️ Breaking

- removed localtunnel (it's not maintained, and was always optional) -
see
[BrowserSync/browser-sync#2059

#### What's Changed

- build(deps): bump nanoid and mocha in /packages/browser-sync-ui by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2015
- build(deps): bump engine.io from 6.2.1 to 6.4.2 in
/packages/browser-sync by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2038
- build(deps-dev): bump webpack from 5.75.0 to 5.76.0 in
/packages/browser-sync-client by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2027
- build(deps): bump json5 from 1.0.1 to 1.0.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2014
- build(deps): bump json-schema and jsprim in /packages/browser-sync-ui
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2042
- fixing nx caching, run tests on nonde 16, 18 & 20 by
[@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2050
- Update README.md by
[@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2051
- adding playwright tests by
[@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2052
- remove localtunnel by
[@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2059

**Full Changelog**:
BrowserSync/browser-sync@v2.29.3...v3.0.1

###
[`v3.0.0`](https://togithub.com/BrowserSync/browser-sync/compare/v2.29.3...v3.0.0)

[Compare
Source](https://togithub.com/BrowserSync/browser-sync/compare/v2.29.3...v3.0.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/MISW/works-misw-jp).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
CaffeeLake pushed a commit to MISW/misw-jp that referenced this pull request Jun 11, 2024
@renovate
Update dependency browser-sync to v3 (#136)
6369261 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [browser-sync](https://browsersync.io/)
([source](https://togithub.com/BrowserSync/browser-sync)) | [`2.29.3` ->
`3.0.2`](https://renovatebot.com/diffs/npm/browser-sync/2.29.3/3.0.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/browser-sync/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/browser-sync/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/browser-sync/2.29.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/browser-sync/2.29.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>BrowserSync/browser-sync (browser-sync)</summary>

###
[`v3.0.2`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v3.0.2)

[Compare
Source](https://togithub.com/BrowserSync/browser-sync/compare/v3.0.1...v3.0.2)

#### What's Changed

- fix: dist path by [@&#8203;bufo24](https://togithub.com/bufo24) in
[BrowserSync/browser-sync#2054
- fix ui-external url by [@&#8203;qdirks](https://togithub.com/qdirks)
in
[BrowserSync/browser-sync#1970

#### New Contributors

- [@&#8203;bufo24](https://togithub.com/bufo24) made their first
contribution in
[BrowserSync/browser-sync#2054
- [@&#8203;qdirks](https://togithub.com/qdirks) made their first
contribution in
[BrowserSync/browser-sync#1970

**Full Changelog**:
BrowserSync/browser-sync@v3.0.1...v3.0.2

###
[`v3.0.1`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v3.0.1)

[Compare
Source](https://togithub.com/BrowserSync/browser-sync/compare/v3.0.0...v3.0.1)

#### ⚠️ Breaking

- removed localtunnel (it's not maintained, and was always optional) -
see
[BrowserSync/browser-sync#2059

#### What's Changed

- build(deps): bump nanoid and mocha in /packages/browser-sync-ui by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2015
- build(deps): bump engine.io from 6.2.1 to 6.4.2 in
/packages/browser-sync by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2038
- build(deps-dev): bump webpack from 5.75.0 to 5.76.0 in
/packages/browser-sync-client by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2027
- build(deps): bump json5 from 1.0.1 to 1.0.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2014
- build(deps): bump json-schema and jsprim in /packages/browser-sync-ui
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[BrowserSync/browser-sync#2042
- fixing nx caching, run tests on nonde 16, 18 & 20 by
[@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2050
- Update README.md by
[@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2051
- adding playwright tests by
[@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2052
- remove localtunnel by
[@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2059

**Full Changelog**:
BrowserSync/browser-sync@v2.29.3...v3.0.1

###
[`v3.0.0`](https://togithub.com/BrowserSync/browser-sync/compare/v2.29.3...v3.0.0)

[Compare
Source](https://togithub.com/BrowserSync/browser-sync/compare/v2.29.3...v3.0.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/MISW/misw-jp).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dippas dippas dippas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qdirks @cossssmin @shakyShane @dippas