Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added visionOS support for Apple Vision Pro #99

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

eugenehp
Copy link
Contributor

@eugenehp eugenehp commented Jun 4, 2024

This PR addresses the comments with target_os specifics.

Tested it with Tier 3 target.

@eugenehp eugenehp changed the title added visionos support feat: Added visionOS support for Apple Vision Pro Jun 4, 2024
@Byron
Copy link
Owner

Byron commented Jun 4, 2024

Thanks a lot! It's funny to think about this crate opening things in 3D ;).

Do you think it's common to just go with ios for visionos support? Is there some rationale?

@Byron Byron added the question label Jun 4, 2024
@eugenehp
Copy link
Contributor Author

eugenehp commented Jun 4, 2024

visionOS has simulation for iOS apps out of the box. However it's flat, and not dimensional.
This crate will enable opening of AR models (USDZ, STL, GLTF) and regular URL links, and so on, including deep links.

If a dev hasn't done much with 3D (Unity, Swift, WebXR, WebGL, etc.) then it's probably easier just to use simulated iOS version, and not to worry about it.

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! Then I think it's fair to do it like this, with the option to add a dedicated visionos later should there be need.

Edit: And here it is the new release.

@Byron Byron merged commit 1efa4cb into Byron:main Jun 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants