Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter ABI supertrait methods from contract entry generation #6402

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Aug 7, 2024

Description

This PR filters out ABI supertrait methods from being considered for contract function entry generation.

Closes #6333.

Tracks SEC-76.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Aug 7, 2024
@tritao tritao self-assigned this Aug 7, 2024
@tritao tritao force-pushed the abi-supertraits-external-methods branch 2 times, most recently from 3a29e53 to c08292e Compare August 7, 2024 14:37
@tritao tritao added the P: critical Should be looked at before anything else label Aug 8, 2024
@tritao tritao force-pushed the abi-supertraits-external-methods branch from c08292e to 6e52130 Compare August 8, 2024 09:51
@tritao tritao force-pushed the abi-supertraits-external-methods branch from 6e52130 to 521ff9f Compare August 8, 2024 09:59
@tritao tritao marked this pull request as ready for review August 8, 2024 10:17
@tritao tritao requested a review from a team as a code owner August 8, 2024 10:17
@tritao tritao enabled auto-merge (squash) August 9, 2024 09:34
@tritao tritao requested a review from IGI-111 August 9, 2024 09:34
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test suite here merely no longer tests the positive. You need to affirm the negative that the method isn't accessible.

@tritao
Copy link
Contributor Author

tritao commented Aug 9, 2024

The test suite here merely no longer tests the positive. You need to affirm the negative that the method isn't accessible.

The new test is checking that calling the method reverts at the VM level.

@tritao tritao merged commit 4c2c384 into FuelLabs:master Aug 14, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen P: critical Should be looked at before anything else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABI supertraits methods are available externally
3 participants