Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

marginnote 4.1.4 #185753

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −7
Open

marginnote 4.1.4 #185753

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d318dd0
Update marginnote.rb
foreverangelwing Sep 17, 2024
f4fa26a
Update marginnote.rb
foreverangelwing Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Casks/m/marginnote.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
cask "marginnote" do

Check failure on line 1 in Casks/m/marginnote.rb

View workflow job for this annotation

GitHub Actions / syntax (macos-14) 

Use `sha256 :no_check` when URL is unversioned.

Check failure on line 1 in Casks/m/marginnote.rb

View workflow job for this annotation

GitHub Actions / test marginnote (macos-13, intel) 

Use `sha256 :no_check` when URL is unversioned.

Check failure on line 1 in Casks/m/marginnote.rb

View workflow job for this annotation

GitHub Actions / test marginnote (macos-13, intel) 

Version '4.14' differs from '4.1.4' retrieved by livecheck.

Check failure on line 1 in Casks/m/marginnote.rb

View workflow job for this annotation

GitHub Actions / test marginnote (macos-14, arm) 

Use `sha256 :no_check` when URL is unversioned.

Check failure on line 1 in Casks/m/marginnote.rb

View workflow job for this annotation

GitHub Actions / test marginnote (macos-14, arm) 

Version '4.14' differs from '4.1.4' retrieved by livecheck.
version "3.7.25"
sha256 "4409e29b6046fc71442f3f2085375dada87b3f06a90892b2334823b0dad75ad3"
version "4.14"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version "4.14"
version "4.1.4"

sha256 "0bea1a7d4c9a27b03045a4196561877c8fa47e9760250ea09afde80550ef5f4d"

url "https://marginstudy.com/mac/MarginNote#{version.major}.dmg",
verified: "marginstudy.com/mac/"
url "https://d.marginnote.cn/MarginNote4.dmg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url "https://d.marginnote.cn/MarginNote4.dmg",
url "https://dist.marginnote.cn/MarginNote#{version}.dmg",

verified: "marginnote.cn/"
name "MarginNote"
desc "E-reader"
homepage "https://www.marginnote.com/"

livecheck do
url "https://dist.marginnote.cn/marginnote#{version.major}.xml"
url "https://dist.marginnote.cn/marginnote4.xml"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url "https://dist.marginnote.cn/marginnote4.xml"
url "https://dist.marginnote.cn/marginnote#{version.major}.xml"

strategy :sparkle, &:short_version
end

auto_updates true
depends_on macos: ">= :sierra"
depends_on macos: ">= :sequoia"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends_on macos: ">= :sequoia"
depends_on macos: ">= :monterey"


app "MarginNote #{version.major}.app"
app "MarginNote 4.app"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
app "MarginNote 4.app"
app "MarginNote #{version.major}.app"


zap trash: [
"~/Library/Application Support/QReader.MarginStudyMac",
Expand Down
Loading