Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] Revert "[FIX] l10n_es_aeat_mod349: origin amount incorrect" #3728

Merged

Conversation

pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza commented Sep 19, 2024

Backport de #3727

This reverts commit 0e7847e.

Este parche fue metido sin advertirse en la migración a 14.0, cuando el PR original de 11.0 no estaba aprobado ni la solución estaba clara que fuera la adecuada:

imagen

y aparte de drenar rendimiento por asignar dos veces la variable origin_amount con mapeos que requieren obtener los datos, está provocando problemas de importes negativos.

@Tecnativa TT50922

@pedrobaeza pedrobaeza added this to the 14.0 milestone Sep 19, 2024
@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3728-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d6b0194 into OCA:14.0 Sep 19, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b7a95e2. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 14.0-rev-l10n_es_aeat_mod349-original_amount branch September 19, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants