Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove null checks before free. Reverses commit eb5395b #643

Merged
merged 5 commits into from
Jul 30, 2024
Merged

fix: remove null checks before free. Reverses commit eb5395b #643

merged 5 commits into from
Jul 30, 2024

Conversation

lemire
Copy link
Member

@lemire lemire commented Jul 27, 2024

See commit eb5395b where I added these checks.

Might fix #345

@lemire lemire requested review from Dr-Emann and Oppen July 27, 2024 14:30
@lemire lemire mentioned this pull request Jul 27, 2024
Closed
Dr-Emann
Dr-Emann approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@Dr-Emann Dr-Emann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but would be okay with going in as is.

README.md Outdated Show resolved Hide resolved
src/containers/run.c Outdated Show resolved Hide resolved
@lemire
Copy link
Member Author

lemire commented Jul 29, 2024

@Oppen @Dr-Emann In the end, we come back almost full circle and we still have the null checks in all but one case.

@lemire
Copy link
Member Author

lemire commented Jul 30, 2024

I am going to merge this because it is cleaner code.

@lemire lemire merged commit 8cc603f into master Jul 30, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oppen Oppen Oppen left review comments

@Dr-Emann Dr-Emann Dr-Emann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we implement standard free semantics for deallocation functions?
3 participants
@lemire @Oppen @Dr-Emann