Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on topBar for Macintosh. closes #501 closes #533 #577

Merged
merged 2 commits into from
Feb 3, 2016
Merged

Improvement on topBar for Macintosh. closes #501 closes #533 #577

merged 2 commits into from
Feb 3, 2016

Conversation

g3offrey
Copy link
Contributor

Hi guys :)
For my first contrib I decided to improve a bit the top toolbar for macintosh (my current OS).

To answer these issues #501 and #533 I mainly changed the close / mini / maxmimize buttons to be smaller and more colorful. And changed a bit the Y position of elements (search bar and buttons).

Here's some screenshots of the differences.
Before :
topbefore

After :
topafter

@weblancaster weblancaster changed the title Improvement on topBar for Macintosh Improvement on topBar for Macintosh. closes #501 closes #533 Feb 1, 2016
@weblancaster
Copy link
Member

Looks great @LeGfrey although can we make them a bit smaller? instead 10px let's try arround 7px

@christopherturner
Copy link

Yeah they should be a bit smaller to be consistent with the OS, but looks awesome, @LeGfrey :)

@Mattijah
Copy link

Mattijah commented Feb 2, 2016

There should be also a slightly darker border around the circle (button) I believe.

*I think the colors still don't completely match the original buttons, how did you get the colors @LeGfrey?

What about:
Red: #FF554E
Yellow: #FFB429
Green: #24C339

(native)
macbuttons

(dark background - photoshop)
macbuttonsdarkbg

(dark background - pixelmator)
macbuttonsdarkbg2

@iduuck
Copy link
Contributor

iduuck commented Feb 2, 2016

Smaller, but no dark border please, because it would make everything blurry. In the screenshot it is also not with a dark border.

@Mattijah
Copy link

Mattijah commented Feb 2, 2016

Well, the first screenshot where is a light background there is definitely something around the circle. Good thing is that Soundnode has a dark bar so maybe it is not needed in this case. I don't know.

@iduuck
Copy link
Contributor

iduuck commented Feb 2, 2016

No I don't think that it is needed. Should be ok to go without a border. But lets just wait for @weblancaster

@weblancaster
Copy link
Member

What @LeGfrey did is good enough for now.. we just need to get a bit smaller from 10px to 7px maybe. no border.

@g3offrey
Copy link
Contributor Author

g3offrey commented Feb 2, 2016

Thank you guys for your feedback 😄
As requested I reduced a bit the size of the buttons (around 3px).

Please tell me if it's still too large or if you prefer a border or a different color.

Concerning colors @Mattijah, I used an eye dropper on a screenshot from apple documentation.
https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/WindowTitleBarToolbar.html#//apple_ref/doc/uid/20000957-CH39-SW1

Here's a screenshot :
newtop

Anyway, I'll be glad to contribute to such a project 😃

@iduuck
Copy link
Contributor

iduuck commented Feb 2, 2016

They need to go up a little now.. And 1-2px more close to each other
On Tue, 2 Feb 2016 at 21:28, Geoffrey notifications@github.com wrote:

Thank you guys for you feedback [image: 😄]
As requested I reduced a bit the size of the buttons (around 3px).
Please tell me if it's still too large.
[image: newtop]
https://cloud.githubusercontent.com/assets/11151445/12763267/bb820d10-c9f3-11e5-9f9b-0d52083f2b74.png


Reply to this email directly or view it on GitHub
#577 (comment)
.

@iduuck
Copy link
Contributor

iduuck commented Feb 3, 2016

And perhaps update the screenshot on the readme

weblancaster added a commit that referenced this pull request Feb 3, 2016
Improvement on topBar for Macintosh. closes #501 closes #533
@weblancaster weblancaster merged commit ad823b9 into Soundnode:master Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants