feat(mat/checkbox): add new aria properties to MatCheckbox #29457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jullierme
requested review from
mmalerba and
andrewseguin
and removed request for
a team
crisbeto
approved these changes
Sep 9, 2024
|
Sorry for the delay here. Can you rebase the PR? |
jullierme
force-pushed
the
add-checkbox-aria-missing-attibutes
branch
from
ab35145
to
6d97933
Compare
Added three new aria properties to MatCheckbox: `aria-expanded`: Indicates whether the checkbox controls the visibility of another element. This should be a boolean value (true or false). `aria-controls`: Specifies the ID of the element that the checkbox controls. `aria-owns`: Specifies the ID of the element that the checkbox visually owns. These attributes will be added to the generated checkbox element if they are specified and won't be present in the HTML if not provided. Also added a small paragraph at the end of the checkbox.md file. Fixes angular#28761
Added three new aria properties to MatCheckbox: `aria-expanded`: Indicates whether the checkbox controls the visibility of another element. This should be a boolean value (true or false). `aria-controls`: Specifies the ID of the element that the checkbox controls. `aria-owns`: Specifies the ID of the element that the checkbox visually owns. These attributes will be added to the generated checkbox element if they are specified and won't be present in the HTML if not provided. Also added a small paragraph at the end of the checkbox.md file. Fixes angular#28761
jullierme
force-pushed
the
add-checkbox-aria-missing-attibutes
branch
from
8166cfc
to
8a6e2d1
Compare
No problem @crisbeto! It's done now :) There is this |
|
You just need to run |
Added three new aria properties to MatCheckbox: `aria-expanded`: Indicates whether the checkbox controls the visibility of another element. This should be a boolean value (true or false). `aria-controls`: Specifies the ID of the element that the checkbox controls. `aria-owns`: Specifies the ID of the element that the checkbox visually owns. These attributes will be added to the generated checkbox element if they are specified and won't be present in the HTML if not provided. Also added a small paragraph at the end of the checkbox.md file. Fixes angular#28761
|
Done, @crisbeto! Thanks for reviewing it and also the public API info. |
crisbeto
added
action: merge
crisbeto
added
the
merge: fix commit message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three new aria properties to MatCheckbox:
aria-expanded: Indicates whether the checkbox controls the visibility of another element. This should be a boolean value (true or false).aria-controls: Specifies the ID of the element that the checkbox controls.aria-owns: Specifies the ID of the element that the checkbox visually owns. These attributes will be added to the generated checkbox element if they are specified, and won't be present in the HTML if not provided. Also added a small paragraph at the end of the checkbox.md file.Fixes #28761