Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(material/tooltip): Avoid unneeded calls to clearTimeout #29643

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Aug 26, 2024

clearTimeout() is surprisingly expensive. Only call it when there's an active timeout.

@kseamon kseamon requested a review from a team as a code owner August 26, 2024 19:02
@kseamon kseamon requested review from crisbeto and amysorto and removed request for a team August 26, 2024 19:02
@kseamon kseamon added the G This is is related to a Google internal issue label Aug 26, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2024
@crisbeto
Copy link
Member

Merging this in since the internal change was merged in already.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 28, 2024
@crisbeto crisbeto merged commit 64cf19c into angular:main Aug 28, 2024
24 of 27 checks passed
crisbeto pushed a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants