fix(cdk/overlay): avoid leaking memory through afterNextRender #29709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
target: patch
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
The `OverlayRef` was triggering an `afterEachRender` and passing in an `EnvironmentInjector`. Under the hood this uses a `DestroyRef` that is never destroyed, because the `EnvironmentInjector` is almost never destroyed. These changes add an explicit `destroy` call to avoid the issue. Fixes angular#29696.
crisbeto
force-pushed
the
29696/menu-leak
branch
from
bae0968
to
01a1c5d
Compare
crisbeto
removed
the
merge: preserve commits
crisbeto
changed the title
|
Off-topic: I found a more attractive name here: |
devversion
approved these changes
Sep 10, 2024
crisbeto
added a commit
that referenced
this pull request
Sep 10, 2024
The `OverlayRef` was triggering an `afterEachRender` and passing in an `EnvironmentInjector`. Under the hood this uses a `DestroyRef` that is never destroyed, because the `EnvironmentInjector` is almost never destroyed. These changes add an explicit `destroy` call to avoid the issue. Fixes #29696. (cherry picked from commit 3a62ab1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OverlayRefwas triggering anafterEachRenderand passing in anEnvironmentInjector. Under the hood this uses aDestroyRefthat is never destroyed, because theEnvironmentInjectoris almost never destroyed.These changes add an explicit
destroycall to avoid the issue.Fixes #29696.