Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor default Mobile Wallet Adapter button UI #1005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Michaelsulistio
Copy link

@Michaelsulistio Michaelsulistio commented Jul 25, 2024

Refactor MWA option in Modal UI

This PR proposes refactoring how the Mobile Wallet Adapter option is presented in the default WalletModal UI. Very open and looking forward to feedback and discussion.

Rationale

The MWA option is an important action on mobile, one which maximizes wallet choice, since it will allow selection of any user-installed wallets which support the agnostic MWA protocol.

This change aims to provide better context clues to the user around its usage. It replaces the current icon and text “Mobile wallet adapter”, which is not self-explanatory for users not familiar with what that means. The new wording is more descriptive and helps users understand the connection with the installed wallet apps on their phone.

Changes

In WalletModal, detect the mobileWalletAdapter and, if present, render:

  • On your phone: header
  • Use an installed wallet button below header
  • If other wallets are present, render a Other wallets: header

Next

If needed, we can additionally create a similar change in the UI for ant-design and material-ui.

Testing

Tested on a local build with the example app across these different test cases, making sure to test that non-MWA modal's are unaffected.

Test Case Platform Screenshot Video
2 Listed Wallets, 0 Collapsed Wallets Android Screenshot 2024-07-25 at 2 39 15 PM Video
2 Listed Wallets, 0 Collapsed Wallets Android Screenshot 2024-07-25 at 2 58 23 PM Video
1 Listed Wallets, 0 Collapsed Wallets iOS Screenshot 2024-07-25 at 2 56 16 PM Video
2 Listed Wallets, 1 Collapsed Wallets iOS Screenshot 2024-07-25 at 2 43 49 PM Video

@Michaelsulistio Michaelsulistio marked this pull request as ready for review July 29, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant