Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String) #1104

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented May 9, 2023

Part of an ongoing effort to phase out StringUtils.
https://issues.apache.org/jira/browse/MNG-6829

Use this link to re-run the recipe: https://public.moderne.io/recipes/org.openrewrite.java.migrate.apache.commons.lang.IsNotEmptyToJdk?organizationId=QXBhY2hlIE1hdmVu

Review requested of @elharo


Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the [Core IT][core-its] successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised none of these change the imports

@timtebeek
Copy link
Contributor Author

Some of these remove imports though right? But only when there's no other methods being called. There's quite a few StringUtils.replace that I'd like to tackle next, which should help remove further imports.

I'd not reconsidered replacing imports yet (going from one string utils implementation to another), as it seemed removing was preferred over replacement. Is that still the case?

We can discuss what to tackle next and how to approach things going forward, as there were other concerns as well such as matching up per project Jira issues. Perhaps we can schedule a brief call or chat at a conference to discuss?

@elharo
Copy link
Contributor

elharo commented May 9, 2023

I didn't notice any import changes. Maybe I just missed them. I'd expect that in some if not all of these files these would be the only methods used from StringUtils so I expected to see some import removals.

@@ -37,7 +37,6 @@
import org.apache.maven.project.MavenProject;
import org.apache.maven.shared.utils.logging.MessageBuilder;
import org.apache.maven.shared.utils.logging.MessageUtils;
import org.codehaus.plexus.util.StringUtils;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks like it is sometimes removing an import. That's good.

@elharo elharo merged commit a831982 into apache:master May 9, 2023
@timtebeek timtebeek deleted the refactor/replace-any-string-utils-is-empty-string-and-is-not-empty-string branch May 9, 2023 23:46
@gnodet gnodet added this to the 4.0.0-alpha-6 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants