Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sso): add client cert and root CA options. Fixes #13545. Fixes #7198. #13546

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Simple-Analysis
Copy link

@Simple-Analysis Simple-Analysis commented Sep 2, 2024

Fixes #13545 and fixes #7198.

Motivation

To enable SSO features by ensuring that communication can occur with SSO provider's endpoint that enforces client certificate authentication.

Modifications

  • Added client certificate options for httpClient used in SSO provider communications
  • Added custom root CA option for httpClient used in SSO provider communications

Verification

Unit tests to ensure certificates are consumed properly.

…pClient. Fixes argoproj#13545 and argoproj#7198.

Signed-off-by: Calvin Harrison <74850112+Simple-Analysis@users.noreply.github.com>
@agilgur5 agilgur5 changed the title feat: Added mTLS and root CA httpClient options for SSO . Fixes #13545 and #7198. feat(sso): add client cert and root CA options. Fixes #13545. Fixes #7198. Sep 2, 2024
@agilgur5 agilgur5 self-assigned this Sep 2, 2024
@agilgur5 agilgur5 added this to the v3.6.0 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSO Provider mTLS / client cert support custom root CA for argo-server SSO
2 participants