Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor service user profiles module #528

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

annarhughes
Copy link
Member

What changes did you make?

  • Refactored service user profiles functionality from utils/ to its own service-user-profiles module
  • Added a catch for mailchimp profile not found error - now creates a mailchimp account if failed to update profile on 404
  • Prevent unnecessary updates to mailchimp and crisp accounts if the only change to the user profile is lastActiveAt and the users profile was already updated today. Mailchimps lastActiveAt field only holds the date as there is no date/time type available - meaning any subsequent updates to this field are redundant

@annarhughes annarhughes merged commit 7cfaee7 into develop Jul 30, 2024
5 checks passed
@annarhughes annarhughes deleted the create-missing-mailchimp-profile branch July 30, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant