Ticket-547 updated sub-user service and controller to use user entity #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annarhughes
requested changes
Aug 14, 2024
There was a problem hiding this comment.
Thanks for addressing this issue @ckirby19 🙏 One type issue to fix and it's ready to be merged!
| req['user'].user.id, | ||
| req['user'].user.email, | ||
| req['userEntity'].user.id, | ||
| req['userEntity'].user.email, |
There was a problem hiding this comment.
Suggested change
| req['userEntity'].user.email, | |
| req['userEntity'].id, | |
| req['userEntity'].email, |
the new userEntity object doesn't have a child user object
There was a problem hiding this comment.
Ahh yes apologies, I have changed that now
eleanorreem
approved these changes
Aug 20, 2024
|
Thanks @ckirby19 looks great 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link / number:
#547
What changes did you make?
Replace use of req["user"] with req["userEntity"] and addressed other issues where needed
Why did you make the changes?
As requested in the ticket as part of a larger refactor
Did you run tests?
Yes, unit and e2e tests