-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NONE) fix: fix component export issue #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global.css ํ์ผ๋ rmp๋ ํฌ์์ import ๊ฐ๋ฅํ๋๋ก ์์ ๋ถํ๋๋ฆฝ๋๋ค.
๋ฒ์ ๋ ์ฌ๋ ค์ฃผ์ธ์~
๋ฆ์ ์๊ฐ๊น์ง ๊ณ ์ ๋ง์ผ์
จ์ต๋๋ค!
๋ฐ์ํ์ต๋๋ค~~ ํ์ธ ๋ถํ๋๋ ค์~~~ |
@@ -1,2 +1,3 @@ | |||
import './global.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_app์์ css file imort ์ํด์ฃผ๋ ์ด์ํ ๊ณณ๋ง ์คํ์ผ์ด ์๊พธ๋๋ ๋ฌธ์ ๊ฐ....
์ด๋ฏธ์ง์ carbon chart ๋ ๋์ผํ ์ด์๊ฐ ์์ด์ _app.tsx์์ import ๋๊ณ ์๋ ๊ฒ์ ํ์ธํ ์ ์์ต๋๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[๊ตฌ๋๋ก ๋ ผ์ํ ์ฌํญ]
- carbon ๋ผ์ด๋ธ๋ฌ๋ฆฌ๊ฐ ์ด๋ป๊ฒ ๋น๋ํ๊ณ ์๋์ง ๋ชจ๋ฆ. cds์์ ๋์ผํ ์ด์๊ฐ ๋ฐ์ํ์ง ์์ ์ ์์
- ํด๋น pr ๋ฐ์ํ๋๋ฐ, ๋์์ธ์์คํ
์ปดํฌ๋ํธ์ ์คํ์ผ์ด ์ ์ฉ๋์ง ์๋๋ค๋ฉด ์๋ ๋ฐฉ์์ ๋์ ํด๋ณผ ์์
- ๋ฐฉ๋ฒ 1. vite ๋น๋ ์ ์ต์ง๋ก index.ts์ css ํ์ผ injectํ๊ฒ๋ ํ๊ธฐ
- ๋ฐฉ๋ฒ 2. css ํ์ผ์ ๋ณ๋๋ก ๋น๋ ๊ฒฐ๊ณผ๋ฌผ์ ํฌํจ
๋ฌธ์ ๊ฐ ๋ฐ์ํ์ง ์์์ผ๋ฉด ์ข๊ฒ ์ง๋ง, ๋ง์ฝ ๋ฐ์ํด๋ 1๋ฒ์ผ๋ก ์ต๋ํ ํด๊ฒฐํด๋ณด๊ฒ ์ต๋๋ค.
css ํ์ผ์ ๋ณ๋๋ก ๋ถ๋ฆฌํ๊ฒ ๋๋ฉด,, ์ฌ์ฉํ๋ ์ธก์์ ์์์ผ ํ๋ ํฌ์ธํธ๊ฐ ํ๋ ๋ ๋๋๊ฑฐ๋๊น์ฅ!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Icon/Table/DatePicker ์ฌ์ฉํด์ผํด์ ๋จผ์ merge ๋ถํ๋๋ฆฝ๋๋ค!
[์งํ ์ํฉ ๊ณต์ ]
|
๐ Jira Ticket Number
โป๏ธ Current situation
1. ๋ฌธ์ ์ํฉ
ํ์ฌ design system์ ์ค์นํด์ ์ฌ์ฉํ๋ ค๊ณ ํ๋ฉด,
Icon์ ํฌํจํด Table๊ณผ DatePicker namespace๋ฅผ ์ฐพ์ ์ ์๋ค๋ ์๋ฌ๊ฐ ๋ฐ์ํ๊ณ ์์ต๋๋ค. (* ์ฌ์ง ์ฐธ๊ณ )
2. ๋ฌธ์ ์์ธ: ํธ๋ฆฌ์์ดํน
๐ก Proposed solution
๐งฉ ํ ์คํธ ๋ฐฉ๋ฒ
๐งโ๐ป Reviewer Nudging
โ Checklist