Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NONE) fix: fix component export issue #77

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

dev-redo
Copy link
Member

@dev-redo dev-redo commented Jun 4, 2024

๐Ÿ”— Jira Ticket Number

  • ADCIO-
  • VILL-

โ™ป๏ธ Current situation

image

1. ๋ฌธ์ œ ์ƒํ™ฉ

ํ˜„์žฌ design system์„ ์„ค์น˜ํ•ด์„œ ์‚ฌ์šฉํ•˜๋ ค๊ณ  ํ•˜๋ฉด,
Icon์„ ํฌํ•จํ•ด Table๊ณผ DatePicker namespace๋ฅผ ์ฐพ์„ ์ˆ˜ ์—†๋‹ค๋Š” ์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. (* ์‚ฌ์ง„ ์ฐธ๊ณ )

2. ๋ฌธ์ œ ์›์ธ: ํŠธ๋ฆฌ์‰์ดํ‚น

  • ์ด์œ ๋ฅผ ํ™•์ธํ•ด๋ณด๋‹ˆ ์–ธ๊ธ‰ํ•œ ์ปดํฌ๋„ŒํŠธ๋ฅผ export ํ•˜๊ณ  ์žˆ์ง€ ์•Š์•„์„œ, ํŠธ๋ฆฌ์‰์ดํ‚น ๋˜์—ˆ์Œ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์‹ค์ œ๋กœ ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ ํŒŒ์ผ(= dist/index.js)์„ ํ™•์ธํ•ด๋ณด๋‹ˆ, ์–ธ๊ธ‰ํ•œ ์ปดํฌ๋„ŒํŠธ๊ฐ€ ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ์— ํฌํ•จ๋˜์ง€ ์•Š์•˜์Œ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ’ก Proposed solution

image
  • ์–ธ๊ธ‰ํ•œ ์ปดํฌ๋„ŒํŠธ๋ฅผ export ํ•˜๊ฒŒ๋” ์ˆ˜์ •ํ•ด์ฃผ์–ด ์ •์ƒ์ ์œผ๋กœ ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ์— ํฌํ•จ๋˜๊ฒŒ๋” ์ˆ˜์ •ํ•ด์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค.
  • cds ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ์„ rmp์— ์ ์šฉํ–ˆ๋”๋‹ˆ ์œ„์™€ ๊ฐ™์ด ์•„์ด์ฝ˜์ด ์ž˜ ๋ณด์—ฌ์ง€๊ณ  ์žˆ๋Š” ๊ฒƒ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿงฉ ํ…Œ์ŠคํŠธ ๋ฐฉ๋ฒ•

  • ํ•ด๋‹น ๋ธŒ๋žœ์น˜์—์„œ pnpm build๋ฅผ ํ•œ๋‹ค.
  • rmp node_modules์˜ @corca-ai/design-system ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์˜ dist ํด๋”๋ฅผ ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ๋กœ ๋ณ€๊ฒฝํ•œ๋‹ค.
  • Icon, Table, DatePicker๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ์ ์šฉ๋˜๋Š”์ง€ ํ™•์ธํ•œ๋‹ค.

๐Ÿง‘โ€๐Ÿ’ป Reviewer Nudging

โœ… Checklist

  • ์ˆ˜์ • ์‚ฌํ•ญ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๋ฅผ ๋งˆ์ณค์Šต๋‹ˆ๋‹ค.
  • ๊ด€๋ จ ๋…ธ์…˜ ๋ฌธ์„œ๋ฅผ ์—…๋ฐ์ดํŠธํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • ๋””์ž์ธ ์‹œ์Šคํ…œ ์ปดํฌ๋„ŒํŠธ์˜ ๊ฒฝ์šฐ rmp PR ๋ฒˆํ˜ธ ์ฒจ๋ถ€ ๋ฐ CDS ๋ผ๋ฒจ์„ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

@dev-redo dev-redo self-assigned this Jun 4, 2024
@dev-redo dev-redo added the bug Something isn't working label Jun 4, 2024
@dev-redo dev-redo marked this pull request as ready for review June 4, 2024 17:44
@dev-redo dev-redo removed the request for review from neverlish June 4, 2024 17:47
Copy link
Collaborator

@dohui-son dohui-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global.css ํŒŒ์ผ๋„ rmp๋ ˆํฌ์—์„œ import ๊ฐ€๋Šฅํ•˜๋„๋ก ์ˆ˜์ • ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.
๋ฒ„์ „๋„ ์˜ฌ๋ ค์ฃผ์„ธ์š”~
๋Šฆ์€ ์‹œ๊ฐ„๊นŒ์ง€ ๊ณ ์ƒ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค!

@dev-redo
Copy link
Member Author

dev-redo commented Jun 5, 2024

global.css ํŒŒ์ผ๋„ rmp๋ ˆํฌ์—์„œ import ๊ฐ€๋Šฅํ•˜๋„๋ก ์ˆ˜์ • ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.
๋ฒ„์ „๋„ ์˜ฌ๋ ค์ฃผ์„ธ์š”~

๋ฐ˜์˜ํ–ˆ์Šต๋‹ˆ๋‹ค~~ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ ค์š”~~~

dohui-son
dohui-son previously approved these changes Jun 5, 2024
@dohui-son dohui-son dismissed their stale review June 5, 2024 02:00

about global.css

@@ -1,2 +1,3 @@
import './global.css';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ฏธ์ง€ ์ฐธ๊ณ ํ•˜์‹œ๋ฉด import '@client/global.scss'; ๊ฐ€ ์žˆ๋Š”๋ฐ์š”. ์ด๊ฒƒ๋•Œ๋ฌธ์— ์ถ”๊ฐ€ ์š”์ฒญ๋“œ๋ฆฐ ๊ฒƒ์ด์—ˆ์Šต๋‹ˆ๋‹ค.
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_app์—์„œ css file imort ์•ˆํ•ด์ฃผ๋‹ˆ ์ด์ƒํ•œ ๊ณณ๋งŒ ์Šคํƒ€์ผ์ด ์‚๊พธ๋‚˜๋Š” ๋ฌธ์ œ๊ฐ€....
์ด๋ฏธ์ง€์˜ carbon chart ๋„ ๋™์ผํ•œ ์ด์Šˆ๊ฐ€ ์žˆ์–ด์„œ _app.tsx์—์„œ import ๋˜๊ณ  ์žˆ๋Š” ๊ฒƒ์„ ํ™•์ธํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

Copy link
Member Author

@dev-redo dev-redo Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dohui-son

[๊ตฌ๋‘๋กœ ๋…ผ์˜ํ•œ ์‚ฌํ•ญ]

  • carbon ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๊ฐ€ ์–ด๋–ป๊ฒŒ ๋นŒ๋“œํ•˜๊ณ  ์žˆ๋Š”์ง€ ๋ชจ๋ฆ„. cds์—์„  ๋™์ผํ•œ ์ด์Šˆ๊ฐ€ ๋ฐœ์ƒํ•˜์ง€ ์•Š์„ ์ˆ˜ ์žˆ์Œ
  • ํ•ด๋‹น pr ๋ฐ˜์˜ํ–ˆ๋Š”๋ฐ, ๋””์ž์ธ์‹œ์Šคํ…œ ์ปดํฌ๋„ŒํŠธ์— ์Šคํƒ€์ผ์ด ์ ์šฉ๋˜์ง€ ์•Š๋Š”๋‹ค๋ฉด ์•„๋ž˜ ๋ฐฉ์‹์„ ๋„์ „ํ•ด๋ณผ ์˜ˆ์ •
    • ๋ฐฉ๋ฒ• 1. vite ๋นŒ๋“œ ์‹œ ์–ต์ง€๋กœ index.ts์— css ํŒŒ์ผ injectํ•˜๊ฒŒ๋” ํ•˜๊ธฐ
    • ๋ฐฉ๋ฒ• 2. css ํŒŒ์ผ์„ ๋ณ„๋„๋กœ ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ์— ํฌํ•จ

๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒํ•˜์ง€ ์•Š์•˜์œผ๋ฉด ์ข‹๊ฒ ์ง€๋งŒ, ๋งŒ์•ฝ ๋ฐœ์ƒํ•ด๋„ 1๋ฒˆ์œผ๋กœ ์ตœ๋Œ€ํ•œ ํ•ด๊ฒฐํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค.
css ํŒŒ์ผ์„ ๋ณ„๋„๋กœ ๋ถ„๋ฆฌํ•˜๊ฒŒ ๋˜๋ฉด,, ์‚ฌ์šฉํ•˜๋Š” ์ธก์—์„œ ์•Œ์•„์•ผ ํ•˜๋Š” ํฌ์ธํŠธ๊ฐ€ ํ•˜๋‚˜ ๋” ๋Š๋Š”๊ฑฐ๋‹ˆ๊นŒ์šฅ!

Copy link
Collaborator

@dohui-son dohui-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon/Table/DatePicker ์‚ฌ์šฉํ•ด์•ผํ•ด์„œ ๋จผ์ € merge ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค!

@dohui-son dohui-son merged commit bd6ed28 into main Jun 5, 2024
@dohui-son dohui-son deleted the fix-fix-component-export-issue branch June 5, 2024 03:10
@dev-redo
Copy link
Member Author

dev-redo commented Jun 5, 2024

[์ง„ํ–‰ ์ƒํ™ฉ ๊ณต์œ ]

  • ๋ฌธ์ œ ์ƒํ™ฉ
    • ์œ„์—์„œ ์–ธ๊ธ‰ํ•œ๋Œ€๋กœ, index.ts์— css๋ฅผ ํฌํ•จํ•˜๊ฒŒ๋” ์„ค์ •์„ ๋ฐ”๊ฟจ๋”๋‹ˆ ์‚ฌ์ง„์ฒ˜๋Ÿผ ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ์— css ํŒŒ์ผ์ด ํฌํ•จ๋˜๋Š” ๊ฒƒ์„ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.
    • ๋ฌธ์ œ๋Š” next.js์˜ ๊ฒฝ์šฐ app.tsx๊ฐ€ ์•„๋‹Œ ๊ณณ์—์„œ cssํŒŒ์ผ์„ exportํ•˜๋ฉด ์•„๋ž˜ ์‚ฌ์ง„์ฒ˜๋Ÿผ ์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ•˜๊ฒŒ ๋ฉ๋‹ˆ๋‹ค.
    • ๋”ฐ๋ผ์„œ css๋ฅผ ๋ณ„๋„์˜ ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ๋กœ ํฌํ•จ์‹œ์ผœ์ฃผ์–ด์•ผ ํ•ฉ๋‹ˆ๋‹ค.
  • ์ˆ˜์ • ๋ฐฉํ–ฅ
    • css ํŒŒ์ผ์„ ๋นŒ๋“œ ๊ฒฐ๊ณผ๋ฌผ์— ํฌํ•จ์‹œํ‚ค๊ณ , ๋ณ„๋„๋กœ package.json์— ํฌํ•จํ•˜๊ฒŒ๋” ๊ตฌ์„ฑํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.
    • ๊ทธ๋ ‡๊ฒŒ ๋˜๋ฉด app.tsx์—์„œ ํ•ด๋‹น cssํŒŒ์ผ์„ importํ•˜๊ณ , ๋””์ž์ธ ์‹œ์Šคํ…œ ์ปดํฌ๋„ŒํŠธ๋Š” css ํŒŒ์ผ์„ importํ•˜์ง€ ์•Š์œผ๋‹ˆ ๋ฌธ์ œ๊ฐ€ ์—†์„ ๊ฒƒ์œผ๋กœ ๋ณด์ž…๋‹ˆ๋‹ค.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants