New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update pr-issue-validator.yaml #3854

Merged

prakarsh-dt merged 2 commits into main from tayalrishabh96-patch-1

Oct 4, 2023

Contributor

tayalrishabh96 commented Sep 1, 2023 •

edited

Loading

added support for following regex :

Fixes https://github.com/devtron-labs/devtron/issues/<issue_number>
Fixes devtron-labs/devtron#<issue_number>
Resolves https://github.com/devtron-labs/devtron/issues/<issue_number>
Resolves devtron-labs/devtron#<issue_number>

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


          Update pr-issue-validator.yaml

48ef401

added support for following regex : 
- Fixes #3482
- Fixes #3482
- Resolves #3482
- Resolves #3482

prakarsh-dt added the PR:Ready-to-Review label


          Update pr-issue-validator.yaml

6fb89de

Trimmed whitespace chartacter '\r' using tr utility

tayalrishabh96 requested review from prakarsh-dt and nishant-d as code owners

September 29, 2023 09:17

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

prakarsh-dt approved these changes

View reviewed changes

prakarsh-dt merged commit 2ecc785 into main

6 checks passed

prakarsh-dt deleted the tayalrishabh96-patch-1 branch

October 4, 2023 07:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:Ready-to-Review