Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added flag to configure ecr repo creation #3963

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Sep 25, 2023

Description

Added SKIP_CREATING_ECR_REPO (defaults to false) env variable to configure ecr repo creation. If set true, then repo creation will not be tried and will be tried if set to false.

Fixes #3965

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


vikramdevtron
vikramdevtron previously approved these changes Sep 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartik-579 kartik-579 merged commit 346317d into main Sep 25, 2023
6 checks passed
@kartik-579 kartik-579 deleted the ecr-repo-create-optional branch September 25, 2023 15:40
Ash-exp pushed a commit that referenced this pull request Sep 27, 2023
* added flag to configure ecr repo creation

* updated var name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Make ECR repo creation configurable
3 participants