Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handled releaseNotExists case for helm type cd pipeline resource tree fetch #4016

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Oct 5, 2023

Description

Release status was being used in helm type cd pipeline but it breaks when a pipeline is migrated from gitOps to helm type and release is not created yet.

Fixes #4017

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


iamayushm
iamayushm previously approved these changes Oct 5, 2023
@kartik-579 kartik-579 changed the title fix: removed releaseStatus for helm type cd pipelines fix: handled releaseNotExists case for helm type cd pipeline resource tree fetch Oct 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kartik-579 kartik-579 merged commit 1bc9422 into main Oct 5, 2023
6 checks passed
@kartik-579 kartik-579 deleted the resource-tree-fix branch October 5, 2023 09:46
ShashwatDadhich pushed a commit that referenced this pull request Oct 12, 2023
… tree fetch (#4016) (#493)

* fix

* added release not exists case

* added release not exists case
ShashwatDadhich pushed a commit that referenced this pull request Oct 12, 2023
* fix: handled releaseNotExists case for helm type cd pipeline resource tree fetch (#4016)

* fix

* added release not exists case

* added release not exists case

* fix: auto post cd not working in case of multiple parallel gitOps pipeline (#4018)

* made pipelineOverride fetching at a single source for updating timelines, triggereing subsequent stages"

* added safety check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Resource tree api giving http 502 Bad Gateway
3 participants