chore: Removed unused jira and migration integration #4498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishant-d
requested review from
vikramdevtron and
kripanshdevtron
as code owners
Ash-exp
changed the title
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| 141558 | Generic High Entropy Secret | 974d1ce | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml | View secret |
| 141558 | Generic High Entropy Secret | 974d1ce | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml | View secret |
| 2763127 | Generic High Entropy Secret | 974d1ce | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml | View secret |
| 2763127 | Generic High Entropy Secret | 974d1ce | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml | View secret |
| 9257608 | Base64 AWS keys | 974d1ce | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Ash-exp
added a commit
that referenced
this pull request
Jan 24, 2024
* chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * moved: const and types to bean * removed: unused const * moved ChartGroup router and rest handler to respective folder --------- Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com>
kartik-579
added a commit
that referenced
this pull request
Feb 1, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * gitOps refactoring * moved gitClient code to a common wrapper service * review changes * wip * fix for unsupported charts * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes --------- Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
7 tasks
Ash-exp
added a commit
that referenced
this pull request
Feb 5, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: sanity after ent sync * added: todo comment * fix: new api added for getting ciPipelineDetails by only ciPipelineId for CLI (#3708) * new api added for getting ciPipelineDetails by only ciPipelineId * appName field added in ci-pipeline struct * appType field added in ci-pipeline struct * code review comments incorporation --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Prakash <prakash.kumar@devtron.ai>
Ash-exp
added a commit
that referenced
this pull request
Feb 7, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: App store services refactoring (#4596) * chore: fixed test file * chore: app store deployment services refactoring * updated todo * chore: dead code removal and app router & rest handler restructuring (#4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <nishant@devtron.ai> * chore: sanity after ent sync * added: todo comment * added: todo comment * chore: fixed gitops auto fix operations in upgrade helm charts * added: nit pointer issue for argocd resource tree * fixed: nil poniter issue for gitops in upgrade deployment * removed: comments --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai>
subhashish-devtron
added a commit
that referenced
this pull request
Feb 12, 2024
…#4602) * removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * gitOps refactoring * moved gitClient code to a common wrapper service * review changes * wip * fix for unsupported charts * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * merging all changes * removing files * ctx changes * factory refactoring * reftactorings * go mod * testing fixes * pr comments 1 * gitcontext * remname gitclient -> gitopsclient --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
kartik-579
added a commit
that referenced
this pull request
Feb 20, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * extracted trigger cd, nats subscriptions from wfDAGExec service * removed gitOpsRepoName fetch logic duplicacy * minor change for cd trigger method * removed redundant imports * extracted deployment bulk trigger publish event logic from workflowDag * extracted manifest creation code from WorkflowDagExecutor * moved WorkflowStatusUpdateHandler * removed old refactored code * wip - extracted k8s op method from workflowDAG part 1 * extracted artifact logic from workflowDAG * extracted artifact logic from workflowDAG * refactoring * replaced slices -> k8s.io/utils/strings/slices import * replaced slices -> k8s.io/utils/strings/slices import * fix prod bug * renamed PrePostStageTriggerService -> preStageTriggerService * fix for rollback * updated common-lib version --------- Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai>
kartik-579
added a commit
that referenced
this pull request
Mar 20, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * extracted trigger cd, nats subscriptions from wfDAGExec service * removed gitOpsRepoName fetch logic duplicacy * minor change for cd trigger method * removed redundant imports * extracted deployment bulk trigger publish event logic from workflowDag * extracted manifest creation code from WorkflowDagExecutor * moved WorkflowStatusUpdateHandler * removed old refactored code * wip - extracted k8s op method from workflowDAG part 1 * extracted artifact logic from workflowDAG * extracted artifact logic from workflowDAG * refactoring * replaced slices -> k8s.io/utils/strings/slices import * replaced slices -> k8s.io/utils/strings/slices import * fix prod bug * renamed PrePostStageTriggerService -> preStageTriggerService * fix for rollback * wip * refactoring pre & post stage service * updated PreCdTriggerService * migrated AsyncTrigger consumer to eventProcessor * review comments * removed whitespaces * migrated ci material topic to processor service * migrated argo app status subsciption to common processor pkg * migrated argo type pipeline publish and process to common pkg * migrated appstore bulk deploy topic * migrated cd bulk deploy topic * migrated appstore helm install status topic * migrated git webhook event publish * minor changes in manifest creation service * minor changes in cd trigger service * minor changes in cd trigger service * wip * minor change in async helm install req handling * wip * updated common lib version(synced with main) * safety check for concurrency in pipeline delete and asyn trigger * updated common-lib version * updated common-lib version to main 5807b130153800727ace993e98b24cb27b8fc1fa --------- Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai>
prakarsh-dt
added a commit
that referenced
this pull request
Mar 28, 2024
* feat: active inactive user phase 3 (#4649) * listing user and group changes * default value chnage * group listing optimisation * wire_gen * order by in group * default values * discard * updated on * case insensitive * script number change * specs * review chnages * sql update * id for user * script number chnage * review comments-1 * review comments * review comments * rest handler remove methods * validation for delete * delete user handling * review comments * review comments * bulk delete user and permission group * legacy code fix from loop in query to bulk query * export csv filters support * Revert "export csv filters support" This reverts commit 4448c9e. * export csv filters * bulk delete support with filters * validation * method break * refactor the method * condition * open api specs * specs * refactoring filters in bulk delete rolegroup * comments * comments * script * group listing * review comments * review comments * review comments * review comments * user delete self-review * error handling * renaming helpers * commets * checks and renaming * last login order * script number change * rolegroup migration * name change * backward compatibility handling * self review name change * chart-group -manager-fix * userrolegroups * change chnage operation * specs update * groups * find by componet id * job project id * sql script chnage * script number change * fix: extra check added for mono-repo migraiton (#4764) * extra check added for mono-repo migraiton * comparison of repoNameWithoutPrefix and appstore name for mono repo condition * refactor * remove prefix * fix * remove-gitops-prefix-oss * refactor * refactor * refactor * added request method in audit logger (#4817) * fix: rolefilters correction with all applications and particular application selected. (#4820) * merging issue resolved * all namespace, cluster, kind remove as it is used in key * removing unnecessary code * fix: 5xx 4.0 iter (#4620) * bugs revert * 4th iter code changes * delete dag exec * initial poc (ongoing) of handling grpc errors * grpc error handling at install helm chart and template services * refactoring * refactor * code review changes with some refactoring * removed unused files * refactor * chore: refactoring v4 (#4775) * removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * extracted trigger cd, nats subscriptions from wfDAGExec service * removed gitOpsRepoName fetch logic duplicacy * minor change for cd trigger method * removed redundant imports * extracted deployment bulk trigger publish event logic from workflowDag * extracted manifest creation code from WorkflowDagExecutor * moved WorkflowStatusUpdateHandler * removed old refactored code * wip - extracted k8s op method from workflowDAG part 1 * extracted artifact logic from workflowDAG * extracted artifact logic from workflowDAG * refactoring * replaced slices -> k8s.io/utils/strings/slices import * replaced slices -> k8s.io/utils/strings/slices import * fix prod bug * renamed PrePostStageTriggerService -> preStageTriggerService * fix for rollback * wip * refactoring pre & post stage service * updated PreCdTriggerService * migrated AsyncTrigger consumer to eventProcessor * review comments * removed whitespaces * migrated ci material topic to processor service * migrated argo app status subsciption to common processor pkg * migrated argo type pipeline publish and process to common pkg * migrated appstore bulk deploy topic * migrated cd bulk deploy topic * migrated appstore helm install status topic * migrated git webhook event publish * minor changes in manifest creation service * minor changes in cd trigger service * minor changes in cd trigger service * wip * minor change in async helm install req handling * wip * updated common lib version(synced with main) * safety check for concurrency in pipeline delete and asyn trigger * updated common-lib version * updated common-lib version to main 5807b130153800727ace993e98b24cb27b8fc1fa --------- Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai> * fix: hide ldap creds in in get req (#4788) * hide ldap creds in in get req * removed unnecessary code * refactor * revert * refactor * pointer binding (#4826) * Adding script to calculate score for pagerduty issues * Update github_pagerduty_issue_score_calculation.py * feat: Branch Divergence Checker Plugin (#4806) * Branch Divergence Checker Plugin * Delete scripts/sql/229_GitHub_branch_divergence_checker_v1.0.down.sql * Delete assets/GitHubBranchDivergenceCheckerlogo.png * Adding assets * Changing asset name * Removing asset * Update 229_github_branch_divergence_checker.up.sql * feat: Added Apply job in k8s plugin (#4828) * feat: Added Devtron CI Trigger Plugin v1.0.0 * feat: Added Apply JOB in k8s Plugin * modified structure * Added error handelling * Removed CI trigger plugin * Migration number changed * logo changed * feat: Information of Linked CI Pipelines on Parent CI Pipeline (#4786) * Refactor ArgoUserService.go by adding a TODO * wip * updated API spec * Update repo and service * Add logging of errors * modified API spec * added total count in query * updated service and rest handler layer * Update router and resthandler * set default req params at rest handler * moved generics to global util * Update resthandler * added tracing for new queries * fixed undefined ctx * Update handler's rbac * update error logs * Update cipipeline repo * added: comments for changes * Change handler * fixed typo and imports * fixed adapter and constants * updated test file errors and mock files * updated API specs * fixed API specs end points * fixed: query errors * fixed: linked cd condition * fixed: typo * fixed: search * fixed nil check for runner query * fixed: append in adapter * fix searchkey to lowercase * Fix duplicated env names * fix pass env array as empty * Fix error logs * fix error * fixed import --------- Co-authored-by: komalreddy3 <koukuntlakomalreddy3@gmail.com> * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * feat:Github Pull Request Closer (#4833) * PR plugin script * Update 230_Github_Pull_Request_Closer.up.sql * Update 230_Github_Pull_Request_Closer.up.sql * Update 230_Github_Pull_Request_Closer.up.sql * Rename 230_Github_Pull_Request_Closer.down.sql to 231_Github_Pull_Request_Closer.down.sql * Rename 230_Github_Pull_Request_Closer.up.sql to 231_Github_Pull_Request_Closer.up.sql * Rename GithubReleasePR.png to GithubPullRequest-Plugin-logo.png * Update 231_Github_Pull_Request_Closer.up.sql --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * chore: Image scanning refactoring (#4802) * added sql * updated event type for job in workflow request * added comments, handling for global cm/cs * fixed json string global cmcs * updated global cm/cs spec * wip * updated sql script number * updated sql script number * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * fix: helm deployements stucked in queued for devtron apps (#4842) * ns not found in case ips is being injected in cluster (#4844) * Delete .github/github_pagerduty_issue_score_calculation.py --------- Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Raunit Verma <155707586+raunit-verma@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Kiran <155609672+kirandevtn@users.noreply.github.com> Co-authored-by: komalreddy3 <koukuntlakomalreddy3@gmail.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
prakarsh-dt
added a commit
that referenced
this pull request
Mar 28, 2024
* misc: Pagerduty issue template change Pagerduty issue template change to seek more information for validating the criticality of the issue. * Update pager-duty.yaml * Update pager-duty.yaml * Update pager-duty.yaml * feat: Adding script to calculate score for pagerduty issues (#4832) * feat: active inactive user phase 3 (#4649) * listing user and group changes * default value chnage * group listing optimisation * wire_gen * order by in group * default values * discard * updated on * case insensitive * script number change * specs * review chnages * sql update * id for user * script number chnage * review comments-1 * review comments * review comments * rest handler remove methods * validation for delete * delete user handling * review comments * review comments * bulk delete user and permission group * legacy code fix from loop in query to bulk query * export csv filters support * Revert "export csv filters support" This reverts commit 4448c9e. * export csv filters * bulk delete support with filters * validation * method break * refactor the method * condition * open api specs * specs * refactoring filters in bulk delete rolegroup * comments * comments * script * group listing * review comments * review comments * review comments * review comments * user delete self-review * error handling * renaming helpers * commets * checks and renaming * last login order * script number change * rolegroup migration * name change * backward compatibility handling * self review name change * chart-group -manager-fix * userrolegroups * change chnage operation * specs update * groups * find by componet id * job project id * sql script chnage * script number change * fix: extra check added for mono-repo migraiton (#4764) * extra check added for mono-repo migraiton * comparison of repoNameWithoutPrefix and appstore name for mono repo condition * refactor * remove prefix * fix * remove-gitops-prefix-oss * refactor * refactor * refactor * added request method in audit logger (#4817) * fix: rolefilters correction with all applications and particular application selected. (#4820) * merging issue resolved * all namespace, cluster, kind remove as it is used in key * removing unnecessary code * fix: 5xx 4.0 iter (#4620) * bugs revert * 4th iter code changes * delete dag exec * initial poc (ongoing) of handling grpc errors * grpc error handling at install helm chart and template services * refactoring * refactor * code review changes with some refactoring * removed unused files * refactor * chore: refactoring v4 (#4775) * removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * extracted trigger cd, nats subscriptions from wfDAGExec service * removed gitOpsRepoName fetch logic duplicacy * minor change for cd trigger method * removed redundant imports * extracted deployment bulk trigger publish event logic from workflowDag * extracted manifest creation code from WorkflowDagExecutor * moved WorkflowStatusUpdateHandler * removed old refactored code * wip - extracted k8s op method from workflowDAG part 1 * extracted artifact logic from workflowDAG * extracted artifact logic from workflowDAG * refactoring * replaced slices -> k8s.io/utils/strings/slices import * replaced slices -> k8s.io/utils/strings/slices import * fix prod bug * renamed PrePostStageTriggerService -> preStageTriggerService * fix for rollback * wip * refactoring pre & post stage service * updated PreCdTriggerService * migrated AsyncTrigger consumer to eventProcessor * review comments * removed whitespaces * migrated ci material topic to processor service * migrated argo app status subsciption to common processor pkg * migrated argo type pipeline publish and process to common pkg * migrated appstore bulk deploy topic * migrated cd bulk deploy topic * migrated appstore helm install status topic * migrated git webhook event publish * minor changes in manifest creation service * minor changes in cd trigger service * minor changes in cd trigger service * wip * minor change in async helm install req handling * wip * updated common lib version(synced with main) * safety check for concurrency in pipeline delete and asyn trigger * updated common-lib version * updated common-lib version to main 5807b130153800727ace993e98b24cb27b8fc1fa --------- Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai> * fix: hide ldap creds in in get req (#4788) * hide ldap creds in in get req * removed unnecessary code * refactor * revert * refactor * pointer binding (#4826) * Adding script to calculate score for pagerduty issues * Update github_pagerduty_issue_score_calculation.py * feat: Branch Divergence Checker Plugin (#4806) * Branch Divergence Checker Plugin * Delete scripts/sql/229_GitHub_branch_divergence_checker_v1.0.down.sql * Delete assets/GitHubBranchDivergenceCheckerlogo.png * Adding assets * Changing asset name * Removing asset * Update 229_github_branch_divergence_checker.up.sql * feat: Added Apply job in k8s plugin (#4828) * feat: Added Devtron CI Trigger Plugin v1.0.0 * feat: Added Apply JOB in k8s Plugin * modified structure * Added error handelling * Removed CI trigger plugin * Migration number changed * logo changed * feat: Information of Linked CI Pipelines on Parent CI Pipeline (#4786) * Refactor ArgoUserService.go by adding a TODO * wip * updated API spec * Update repo and service * Add logging of errors * modified API spec * added total count in query * updated service and rest handler layer * Update router and resthandler * set default req params at rest handler * moved generics to global util * Update resthandler * added tracing for new queries * fixed undefined ctx * Update handler's rbac * update error logs * Update cipipeline repo * added: comments for changes * Change handler * fixed typo and imports * fixed adapter and constants * updated test file errors and mock files * updated API specs * fixed API specs end points * fixed: query errors * fixed: linked cd condition * fixed: typo * fixed: search * fixed nil check for runner query * fixed: append in adapter * fix searchkey to lowercase * Fix duplicated env names * fix pass env array as empty * Fix error logs * fix error * fixed import --------- Co-authored-by: komalreddy3 <koukuntlakomalreddy3@gmail.com> * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * feat:Github Pull Request Closer (#4833) * PR plugin script * Update 230_Github_Pull_Request_Closer.up.sql * Update 230_Github_Pull_Request_Closer.up.sql * Update 230_Github_Pull_Request_Closer.up.sql * Rename 230_Github_Pull_Request_Closer.down.sql to 231_Github_Pull_Request_Closer.down.sql * Rename 230_Github_Pull_Request_Closer.up.sql to 231_Github_Pull_Request_Closer.up.sql * Rename GithubReleasePR.png to GithubPullRequest-Plugin-logo.png * Update 231_Github_Pull_Request_Closer.up.sql --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * chore: Image scanning refactoring (#4802) * added sql * updated event type for job in workflow request * added comments, handling for global cm/cs * fixed json string global cmcs * updated global cm/cs spec * wip * updated sql script number * updated sql script number * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * fix: helm deployements stucked in queued for devtron apps (#4842) * ns not found in case ips is being injected in cluster (#4844) * Delete .github/github_pagerduty_issue_score_calculation.py --------- Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Raunit Verma <155707586+raunit-verma@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Kiran <155609672+kirandevtn@users.noreply.github.com> Co-authored-by: komalreddy3 <koukuntlakomalreddy3@gmail.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * Adding scritps to calculate score (#4848) * Adding scritps to calculate score * Update github_pagerduty_score_calculation.yml --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> --------- Co-authored-by: Yashasvi17 <155513200+YashasviDevtron@users.noreply.github.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Raunit Verma <155707586+raunit-verma@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Kiran <155609672+kirandevtn@users.noreply.github.com> Co-authored-by: komalreddy3 <koukuntlakomalreddy3@gmail.com>
Ash-exp
added a commit
that referenced
this pull request
Apr 8, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: App store services refactoring (#4596) * chore: fixed test file * chore: app store deployment services refactoring * updated todo * chore: dead code removal and app router & rest handler restructuring (#4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <nishant@devtron.ai> * chore: sanity after ent sync * added: todo comment * added: todo comment * chore: fixed gitops auto fix operations in upgrade helm charts * added: nit pointer issue for argocd resource tree * fixed: nil poniter issue for gitops in upgrade deployment * chore: install Helm chart flow refactoring * removed: comments * chore: broken down AppStoreDeploymentService interface * fix: install apps audit logs * chore: update env name usgae * chore: fixed main merge changes * updated env var parsing * moved attribute const to bean * removed unused dependency injection * chore: updated alias name * updated: test file * updated wire file * fixed: nil pointer issue * fixed: pg no row issue * fixed: dependency injection * fix: adapter data provider methods * fix: data provider methods * wip * fix: helm app project link * fixed panic on bulk trigger chart group event * fixed gitops validations * fixed delpoyment histroy status for manifest download * App store chore refactoring v4 sync oss (#4778) * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com>
Laeeqdev
pushed a commit
that referenced
this pull request
Apr 9, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: App store services refactoring (#4596) * chore: fixed test file * chore: app store deployment services refactoring * updated todo * chore: dead code removal and app router & rest handler restructuring (#4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <nishant@devtron.ai> * chore: sanity after ent sync * added: todo comment * added: todo comment * chore: fixed gitops auto fix operations in upgrade helm charts * added: nit pointer issue for argocd resource tree * fixed: nil poniter issue for gitops in upgrade deployment * chore: install Helm chart flow refactoring * removed: comments * chore: broken down AppStoreDeploymentService interface * fix: install apps audit logs * chore: update env name usgae * chore: fixed main merge changes * updated env var parsing * moved attribute const to bean * removed unused dependency injection * chore: updated alias name * updated: test file * updated wire file * fixed: nil pointer issue * fixed: pg no row issue * fixed: dependency injection * fix: adapter data provider methods * fix: data provider methods * wip * fix: helm app project link * fixed panic on bulk trigger chart group event * fixed gitops validations * fixed delpoyment histroy status for manifest download * App store chore refactoring v4 sync oss (#4778) * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com>
Laeeqdev
added a commit
that referenced
this pull request
Apr 9, 2024
* duplicate workflow name bug resolved * refactored code * completed dev testing and code * PR code review comments resolved * resolved PR code review comments * resolved PR code review comments final * misc: Refactoring Pagerduty Issue Calculator script (#4856) * Modifying pager duty python script * Updated CODEOWNERS --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * feat: Add support for git hash in the app and app group overview section _revised (#4836) * Revised the api for handelling the overview git commits part using CiArtifact table only * Removed unnecessary comments * optimized the loop and intialization * used maps instead of slices * removed unused comments * modified the GetUniqueArtifactIds * Removed error from util function * renamed the function as generateArtifactIDCommitMap * feat:MailMaster Plugin v1.0 (#4825) * MailMaster Plugin v1.0 * Update 232_mailmaster.up.sql Updated Variable Names * Rename 232_mailmaster.down.sql to 233_mailmaster.down.sql * Rename 232_mailmaster.up.sql to 233_mailmaster.up.sql * 233_mailmaster.up.sql --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * return nil,err on git material fetch error (#4857) * removed code for gitops repo migration in devtron apps (#4838) Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com> * fix: update argo app repo url in patch (#4876) * fix: injected app-serveice dependency into DeployedApplicationEventProcessor service (#4875) * fix: depandabot version upgrade (#4792) * dependabot version upgrade * dependabot version upgrade * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * argo assets deletion reverted * syncing specifig chart (#4631) * fix: use JoinCookie method (#4892) * chore: Resource mapping refactoring (#4813) * change sync * vars * refactor * fix: use JoinCookie method (#4892) * sql file merged --------- Co-authored-by: adi6859 <aditya.ar1909@gmail.com> Co-authored-by: Gireesh Naidu <111440205+gireesh-devtron@users.noreply.github.com> * fix: rbac fix in case of project in upper case (#4840) * lower case rbac objects * lower case * lower * chore: App Store refactoring v4 (#4647) * removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: App store services refactoring (#4596) * chore: fixed test file * chore: app store deployment services refactoring * updated todo * chore: dead code removal and app router & rest handler restructuring (#4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <nishant@devtron.ai> * chore: sanity after ent sync * added: todo comment * added: todo comment * chore: fixed gitops auto fix operations in upgrade helm charts * added: nit pointer issue for argocd resource tree * fixed: nil poniter issue for gitops in upgrade deployment * chore: install Helm chart flow refactoring * removed: comments * chore: broken down AppStoreDeploymentService interface * fix: install apps audit logs * chore: update env name usgae * chore: fixed main merge changes * updated env var parsing * moved attribute const to bean * removed unused dependency injection * chore: updated alias name * updated: test file * updated wire file * fixed: nil pointer issue * fixed: pg no row issue * fixed: dependency injection * fix: adapter data provider methods * fix: data provider methods * wip * fix: helm app project link * fixed panic on bulk trigger chart group event * fixed gitops validations * fixed delpoyment histroy status for manifest download * App store chore refactoring v4 sync oss (#4778) * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com> * fix: deprecate latest in app store app version (#4896) * fix: deprecate latest flag from app_store application_version and increase varchar len for some columns * fix: deprecate latest flag from app_store application_version and increase varchar len for some columns * fix: remove digest column length update * chore: migration support for notification db changes (#4906) * migration support for notification db changes * updated query with internal flag * feat: Added the Devtron CI Trigger Plugin (#4902) (#4908) * Added the Devtron CI Trigger Plugin * Rename 235_devtron_ci_trigger_plugin.down.sql to 236_devtron_ci_trigger_plugin.down.sql * Rename 235_devtron_ci_trigger_plugin.up.sql to 236_devtron_ci_trigger_plugin.up.sql * Rename 236_devtron_ci_trigger_plugin.down.sql to 237_devtron_ci_trigger_plugin.down.sql * Rename 236_devtron_ci_trigger_plugin.up.sql to 237_devtron_ci_trigger_plugin.up.sql --------- Co-authored-by: Yashasvi17 <155513200+YashasviDevtron@users.noreply.github.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> Co-authored-by: Rajeev Ranjan <90333766+RajeevRanjan27@users.noreply.github.com> Co-authored-by: akshatsinha007 <156403098+akshatsinha007@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com> Co-authored-by: Gireesh Naidu <111440205+gireesh-devtron@users.noreply.github.com> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com> Co-authored-by: iamayushm <32041961+iamayushm@users.noreply.github.com> Co-authored-by: subhashish-devtron <129164905+subhashish-devtron@users.noreply.github.com> Co-authored-by: adi6859 <aditya.ar1909@gmail.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com> Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Kiran <155609672+kirandevtn@users.noreply.github.com>
komalreddy3
added a commit
that referenced
this pull request
May 28, 2024
* misc: Pagerduty issue template change Pagerduty issue template change to seek more information for validating the criticality of the issue. * Update pager-duty.yaml * Update pager-duty.yaml * Update pager-duty.yaml * feat: Adding script to calculate score for pagerduty issues (#4832) * feat: active inactive user phase 3 (#4649) * listing user and group changes * default value chnage * group listing optimisation * wire_gen * order by in group * default values * discard * updated on * case insensitive * script number change * specs * review chnages * sql update * id for user * script number chnage * review comments-1 * review comments * review comments * rest handler remove methods * validation for delete * delete user handling * review comments * review comments * bulk delete user and permission group * legacy code fix from loop in query to bulk query * export csv filters support * Revert "export csv filters support" This reverts commit 4448c9e. * export csv filters * bulk delete support with filters * validation * method break * refactor the method * condition * open api specs * specs * refactoring filters in bulk delete rolegroup * comments * comments * script * group listing * review comments * review comments * review comments * review comments * user delete self-review * error handling * renaming helpers * commets * checks and renaming * last login order * script number change * rolegroup migration * name change * backward compatibility handling * self review name change * chart-group -manager-fix * userrolegroups * change chnage operation * specs update * groups * find by componet id * job project id * sql script chnage * script number change * fix: extra check added for mono-repo migraiton (#4764) * extra check added for mono-repo migraiton * comparison of repoNameWithoutPrefix and appstore name for mono repo condition * refactor * remove prefix * fix * remove-gitops-prefix-oss * refactor * refactor * refactor * added request method in audit logger (#4817) * fix: rolefilters correction with all applications and particular application selected. (#4820) * merging issue resolved * all namespace, cluster, kind remove as it is used in key * removing unnecessary code * fix: 5xx 4.0 iter (#4620) * bugs revert * 4th iter code changes * delete dag exec * initial poc (ongoing) of handling grpc errors * grpc error handling at install helm chart and template services * refactoring * refactor * code review changes with some refactoring * removed unused files * refactor * chore: refactoring v4 (#4775) * removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * extracted trigger cd, nats subscriptions from wfDAGExec service * removed gitOpsRepoName fetch logic duplicacy * minor change for cd trigger method * removed redundant imports * extracted deployment bulk trigger publish event logic from workflowDag * extracted manifest creation code from WorkflowDagExecutor * moved WorkflowStatusUpdateHandler * removed old refactored code * wip - extracted k8s op method from workflowDAG part 1 * extracted artifact logic from workflowDAG * extracted artifact logic from workflowDAG * refactoring * replaced slices -> k8s.io/utils/strings/slices import * replaced slices -> k8s.io/utils/strings/slices import * fix prod bug * renamed PrePostStageTriggerService -> preStageTriggerService * fix for rollback * wip * refactoring pre & post stage service * updated PreCdTriggerService * migrated AsyncTrigger consumer to eventProcessor * review comments * removed whitespaces * migrated ci material topic to processor service * migrated argo app status subsciption to common processor pkg * migrated argo type pipeline publish and process to common pkg * migrated appstore bulk deploy topic * migrated cd bulk deploy topic * migrated appstore helm install status topic * migrated git webhook event publish * minor changes in manifest creation service * minor changes in cd trigger service * minor changes in cd trigger service * wip * minor change in async helm install req handling * wip * updated common lib version(synced with main) * safety check for concurrency in pipeline delete and asyn trigger * updated common-lib version * updated common-lib version to main 5807b130153800727ace993e98b24cb27b8fc1fa --------- Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai> * fix: hide ldap creds in in get req (#4788) * hide ldap creds in in get req * removed unnecessary code * refactor * revert * refactor * pointer binding (#4826) * Adding script to calculate score for pagerduty issues * Update github_pagerduty_issue_score_calculation.py * feat: Branch Divergence Checker Plugin (#4806) * Branch Divergence Checker Plugin * Delete scripts/sql/229_GitHub_branch_divergence_checker_v1.0.down.sql * Delete assets/GitHubBranchDivergenceCheckerlogo.png * Adding assets * Changing asset name * Removing asset * Update 229_github_branch_divergence_checker.up.sql * feat: Added Apply job in k8s plugin (#4828) * feat: Added Devtron CI Trigger Plugin v1.0.0 * feat: Added Apply JOB in k8s Plugin * modified structure * Added error handelling * Removed CI trigger plugin * Migration number changed * logo changed * feat: Information of Linked CI Pipelines on Parent CI Pipeline (#4786) * Refactor ArgoUserService.go by adding a TODO * wip * updated API spec * Update repo and service * Add logging of errors * modified API spec * added total count in query * updated service and rest handler layer * Update router and resthandler * set default req params at rest handler * moved generics to global util * Update resthandler * added tracing for new queries * fixed undefined ctx * Update handler's rbac * update error logs * Update cipipeline repo * added: comments for changes * Change handler * fixed typo and imports * fixed adapter and constants * updated test file errors and mock files * updated API specs * fixed API specs end points * fixed: query errors * fixed: linked cd condition * fixed: typo * fixed: search * fixed nil check for runner query * fixed: append in adapter * fix searchkey to lowercase * Fix duplicated env names * fix pass env array as empty * Fix error logs * fix error * fixed import --------- Co-authored-by: komalreddy3 <koukuntlakomalreddy3@gmail.com> * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * feat:Github Pull Request Closer (#4833) * PR plugin script * Update 230_Github_Pull_Request_Closer.up.sql * Update 230_Github_Pull_Request_Closer.up.sql * Update 230_Github_Pull_Request_Closer.up.sql * Rename 230_Github_Pull_Request_Closer.down.sql to 231_Github_Pull_Request_Closer.down.sql * Rename 230_Github_Pull_Request_Closer.up.sql to 231_Github_Pull_Request_Closer.up.sql * Rename GithubReleasePR.png to GithubPullRequest-Plugin-logo.png * Update 231_Github_Pull_Request_Closer.up.sql --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * chore: Image scanning refactoring (#4802) * added sql * updated event type for job in workflow request * added comments, handling for global cm/cs * fixed json string global cmcs * updated global cm/cs spec * wip * updated sql script number * updated sql script number * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * Update github_pagerduty_score_calculation.yml * Update github_pagerduty_issue_score_calculation.py * fix: helm deployements stucked in queued for devtron apps (#4842) * ns not found in case ips is being injected in cluster (#4844) * Delete .github/github_pagerduty_issue_score_calculation.py --------- Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Raunit Verma <155707586+raunit-verma@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Kiran <155609672+kirandevtn@users.noreply.github.com> Co-authored-by: komalreddy3 <koukuntlakomalreddy3@gmail.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * Adding scritps to calculate score (#4848) * Adding scritps to calculate score * Update github_pagerduty_score_calculation.yml --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> --------- Co-authored-by: Yashasvi17 <155513200+YashasviDevtron@users.noreply.github.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Raunit Verma <155707586+raunit-verma@users.noreply.github.com> Co-authored-by: kartik-579 <84493919+kartik-579@users.noreply.github.com> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Kiran <155609672+kirandevtn@users.noreply.github.com> Co-authored-by: komalreddy3 <koukuntlakomalreddy3@gmail.com>
komalreddy3
pushed a commit
that referenced
this pull request
May 28, 2024
* removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: App store services refactoring (#4596) * chore: fixed test file * chore: app store deployment services refactoring * updated todo * chore: dead code removal and app router & rest handler restructuring (#4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <nishant@devtron.ai> * chore: sanity after ent sync * added: todo comment * added: todo comment * chore: fixed gitops auto fix operations in upgrade helm charts * added: nit pointer issue for argocd resource tree * fixed: nil poniter issue for gitops in upgrade deployment * chore: install Helm chart flow refactoring * removed: comments * chore: broken down AppStoreDeploymentService interface * fix: install apps audit logs * chore: update env name usgae * chore: fixed main merge changes * updated env var parsing * moved attribute const to bean * removed unused dependency injection * chore: updated alias name * updated: test file * updated wire file * fixed: nil pointer issue * fixed: pg no row issue * fixed: dependency injection * fix: adapter data provider methods * fix: data provider methods * wip * fix: helm app project link * fixed panic on bulk trigger chart group event * fixed gitops validations * fixed delpoyment histroy status for manifest download * App store chore refactoring v4 sync oss (#4778) * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com>
komalreddy3
pushed a commit
that referenced
this pull request
May 28, 2024
* duplicate workflow name bug resolved * refactored code * completed dev testing and code * PR code review comments resolved * resolved PR code review comments * resolved PR code review comments final * misc: Refactoring Pagerduty Issue Calculator script (#4856) * Modifying pager duty python script * Updated CODEOWNERS --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * feat: Add support for git hash in the app and app group overview section _revised (#4836) * Revised the api for handelling the overview git commits part using CiArtifact table only * Removed unnecessary comments * optimized the loop and intialization * used maps instead of slices * removed unused comments * modified the GetUniqueArtifactIds * Removed error from util function * renamed the function as generateArtifactIDCommitMap * feat:MailMaster Plugin v1.0 (#4825) * MailMaster Plugin v1.0 * Update 232_mailmaster.up.sql Updated Variable Names * Rename 232_mailmaster.down.sql to 233_mailmaster.down.sql * Rename 232_mailmaster.up.sql to 233_mailmaster.up.sql * 233_mailmaster.up.sql --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> * return nil,err on git material fetch error (#4857) * removed code for gitops repo migration in devtron apps (#4838) Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com> * fix: update argo app repo url in patch (#4876) * fix: injected app-serveice dependency into DeployedApplicationEventProcessor service (#4875) * fix: depandabot version upgrade (#4792) * dependabot version upgrade * dependabot version upgrade * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * argo assets deletion reverted * syncing specifig chart (#4631) * fix: use JoinCookie method (#4892) * chore: Resource mapping refactoring (#4813) * change sync * vars * refactor * fix: use JoinCookie method (#4892) * sql file merged --------- Co-authored-by: adi6859 <aditya.ar1909@gmail.com> Co-authored-by: Gireesh Naidu <111440205+gireesh-devtron@users.noreply.github.com> * fix: rbac fix in case of project in upper case (#4840) * lower case rbac objects * lower case * lower * chore: App Store refactoring v4 (#4647) * removed registerInArgo multiple impls * extracted app metrics code * migrated envLevel app metrics code to new service * chore: Removed unused jira and migration integration (#4498) * removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chore: App store dead code cleanup and restructuring (#4497) * moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> * chart ref refactoring * removed infra metrics db calls * moved app metrics repositories from /internal to /pkg * moved: const and types to bean * removed: unused const * review comments * migrated some methods from chartService to chartRefService * added dt validation service interface * minor refactoring * moved validation method - 1 * wip * removed redundant appMetrics req obj * moved app metrics bindings to wireset * removed multiple dead code * remove redundant dependency * moved ChartGroup router and rest handler to respective folder * stage 1 * gitOps refactoring * moved gitClient code to a common wrapper service * chore: AppStoreDeployment Install flow refactoring * review changes * wip * fix for unsupported charts * refactoring: App Store deployment services * minor cleanup * renamed remote package to git * renamed gitOpsRemoteOpService If and impl * migrated usages of gitService to gitOperationService * shifted git service and all gitOps clients to pkg * gitops repository usages refactor * refactored gitOpsRepository usages * gitlab client creation refactoring * renamed util/ChartService * reverted renaming changes * reverted renaming changes * reverted renaming changes * wip * wip * removed typo * changes * changes * chore: App store services refactoring (#4596) * chore: fixed test file * chore: app store deployment services refactoring * updated todo * chore: dead code removal and app router & rest handler restructuring (#4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <nishant@devtron.ai> * chore: sanity after ent sync * added: todo comment * added: todo comment * chore: fixed gitops auto fix operations in upgrade helm charts * added: nit pointer issue for argocd resource tree * fixed: nil poniter issue for gitops in upgrade deployment * chore: install Helm chart flow refactoring * removed: comments * chore: broken down AppStoreDeploymentService interface * fix: install apps audit logs * chore: update env name usgae * chore: fixed main merge changes * updated env var parsing * moved attribute const to bean * removed unused dependency injection * chore: updated alias name * updated: test file * updated wire file * fixed: nil pointer issue * fixed: pg no row issue * fixed: dependency injection * fix: adapter data provider methods * fix: data provider methods * wip * fix: helm app project link * fixed panic on bulk trigger chart group event * fixed gitops validations * fixed delpoyment histroy status for manifest download * App store chore refactoring v4 sync oss (#4778) * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored * code refactored --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com> --------- Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com> * fix: deprecate latest in app store app version (#4896) * fix: deprecate latest flag from app_store application_version and increase varchar len for some columns * fix: deprecate latest flag from app_store application_version and increase varchar len for some columns * fix: remove digest column length update * chore: migration support for notification db changes (#4906) * migration support for notification db changes * updated query with internal flag * feat: Added the Devtron CI Trigger Plugin (#4902) (#4908) * Added the Devtron CI Trigger Plugin * Rename 235_devtron_ci_trigger_plugin.down.sql to 236_devtron_ci_trigger_plugin.down.sql * Rename 235_devtron_ci_trigger_plugin.up.sql to 236_devtron_ci_trigger_plugin.up.sql * Rename 236_devtron_ci_trigger_plugin.down.sql to 237_devtron_ci_trigger_plugin.down.sql * Rename 236_devtron_ci_trigger_plugin.up.sql to 237_devtron_ci_trigger_plugin.up.sql --------- Co-authored-by: Yashasvi17 <155513200+YashasviDevtron@users.noreply.github.com> Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com> Co-authored-by: Rajeev Ranjan <90333766+RajeevRanjan27@users.noreply.github.com> Co-authored-by: akshatsinha007 <156403098+akshatsinha007@users.noreply.github.com> Co-authored-by: Prakash <prakash.kumar@devtron.ai> Co-authored-by: Vikram <73224103+vikramdevtron@users.noreply.github.com> Co-authored-by: Gireesh Naidu <111440205+gireesh-devtron@users.noreply.github.com> Co-authored-by: Shashwat Dadhich <92629050+ShashwatDadhich@users.noreply.github.com> Co-authored-by: iamayushm <32041961+iamayushm@users.noreply.github.com> Co-authored-by: subhashish-devtron <129164905+subhashish-devtron@users.noreply.github.com> Co-authored-by: adi6859 <aditya.ar1909@gmail.com> Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com> Co-authored-by: kartik-579 <kartik@devtron.ai> Co-authored-by: Nishant <58689354+nishant-d@users.noreply.github.com> Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Kiran <155609672+kirandevtn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4532
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?