fix: ci-cd count per day in telemetry data #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalreddy3
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
Ash-exp
requested changes
Apr 12, 2024
internal/sql/repository/pipelineConfig/CdWorfkflowRepository.go
Outdated
Show resolved
Hide resolved
internal/sql/repository/pipelineConfig/CdWorfkflowRepository.go
Outdated
Show resolved
Hide resolved
Ash-exp
previously approved these changes
Apr 16, 2024
Ash-exp
requested changes
Apr 19, 2024
internal/sql/repository/dockerRegistry/DockerArtifactStoreRepository.go
Outdated
Show resolved
Hide resolved
nishant-d
requested changes
Apr 19, 2024
nishant-d
approved these changes
Apr 19, 2024
Ash-exp
approved these changes
Apr 22, 2024
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10220829 | Triggered | Generic High Entropy Secret | f849e06 | charts/devtron/devtron-bom.yaml | View secret |
| 10220829 | Triggered | Generic High Entropy Secret | f849e06 | charts/devtron/values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
komalreddy3
added a commit
that referenced
this pull request
May 28, 2024
* fix: ci-cd count * update queries * update queries to go-pg instead of raw * remove omit empty * summarycron expr change * refactor * type fix * remove comments * refactor query * typo * docker query * refactor * fetching to retrieving * remove unnecessary column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4886
Added fields to TelemetryEventDto
Checklist:
Does this PR introduce a user-facing change?