Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: containers are missing from app-details page in argocd app #4973

Merged
merged 12 commits into from
May 14, 2024

Conversation

ShashwatDadhich
Copy link
Contributor

@ShashwatDadhich ShashwatDadhich commented Apr 19, 2024

Description

Containers is missing from app-details page.

Fixes #4944

How Has This Been Tested?

  • Tested locally
  • Tested by deploying in VM.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.](fix: dependabot version upgrade)

@ShashwatDadhich ShashwatDadhich changed the title fixed fix: containers are missing from app-details page in argocd app Apr 22, 2024
Copy link

gitguardian bot commented Apr 22, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10220829 Triggered Generic High Entropy Secret d13339f charts/devtron/devtron-bom.yaml View secret
10220829 Triggered Generic High Entropy Secret d13339f charts/devtron/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShashwatDadhich ShashwatDadhich merged commit 211a1e4 into main May 14, 2024
7 checks passed
@ShashwatDadhich ShashwatDadhich deleted the container_fix branch May 14, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Containers is missing from app-details page
3 participants