Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Added Linked CI with Child Info + Runtime Build Parameters #4991

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

ashokdevtron
Copy link
Contributor

Added the following to our existing docs:

  • Passing Build Parameter section in Application & Application Group docs
  • Modified Linked CI section to include Child Info
  • RBAC and snapshots included

@ashokdevtron ashokdevtron self-assigned this Apr 22, 2024
@ashokdevtron ashokdevtron added the documentation Improvements or additions to documentation label Apr 22, 2024
Copy link

gitguardian bot commented Apr 22, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10220829 Triggered Generic High Entropy Secret 7c24ba7 charts/devtron/values.yaml View secret
10220829 Triggered Generic High Entropy Secret 7c24ba7 charts/devtron/devtron-bom.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ashokdevtron ashokdevtron changed the title doc: Added Linked CI with Child Info + Runtime Build Parameters" doc: Added Linked CI with Child Info + Runtime Build Parameters Apr 22, 2024
docs/user-guide/application-groups.md Outdated Show resolved Hide resolved
docs/user-guide/deploying-application/triggering-ci.md Outdated Show resolved Hide resolved
docs/user-guide/deploying-application/triggering-ci.md Outdated Show resolved Hide resolved
abhibhaw
abhibhaw previously approved these changes Apr 22, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashokdevtron ashokdevtron merged commit be3aa05 into main Apr 24, 2024
5 checks passed
@ashokdevtron ashokdevtron deleted the april-docup branch April 24, 2024 10:28
komalreddy3 pushed a commit that referenced this pull request May 28, 2024
* Added LinkedCI with Child Information

* Added Build Parameters Guide in App & App Group

* PM Feedback Incorporated

* PM Feedback - Revision

* Added Enterprise Tag in Hintblock - AG Build Param

* Removed unappealing full-stop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants