Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Added kubectl port-fwd section in RB #5139

Merged
merged 5 commits into from
May 21, 2024
Merged

doc: Added kubectl port-fwd section in RB #5139

merged 5 commits into from
May 21, 2024

Conversation

ashokdevtron
Copy link
Contributor

@ashokdevtron ashokdevtron commented May 21, 2024

  • Section created in resource browser doc
  • Added snaps and gifs wherever required
  • Included sample kubeconfig content
  • Linked to official kubectl docs wherever required
  • Added session token method for non-superadmins

@ashokdevtron ashokdevtron added the documentation Improvements or additions to documentation label May 21, 2024
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tokens can only be generated by superadmins, what if the user is not superadmin. Hack: You can get session token from cookie
  2. Default kubeconfig should be simplified so that user can copy and use it.
  3. Assuming you have deactivated the token used in the demo GIF

docs/user-guide/resource-browser.md Show resolved Hide resolved
@ashokdevtron
Copy link
Contributor Author

  1. Tokens can only be generated by superadmins, what if the user is not superadmin. Hack: You can get session token from cookie
  2. Default kubeconfig should be simplified so that user can copy and use it.
  3. Assuming you have deactivated the token used in the demo GIF
  1. Done. Added the session token technique in the doc.
  2. Done.
  3. Yes, the token shown in GIF was not a real one, it was purposely modified.

@ashokdevtron ashokdevtron self-assigned this May 21, 2024
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ashokdevtron ashokdevtron merged commit 7119c08 into main May 21, 2024
8 checks passed
@ashokdevtron ashokdevtron deleted the port-fwd-doc branch May 21, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants