Added new gameplay video options #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: - minecraft-2 - multiversus - fall-guys - steep as options for background gameplay
Added: - minecraft-2 - multiversus - fall-guys - steep as options for background gameplay also CONSTANTS.py didn't seem to exist in the develop branch
OpenSourceSimon
approved these changes
Nov 2, 2022
|
Do you have permission from the video creator? |
`fall-guys` and `multiversus` where changed
Hi I have just checked over and replaced 2 of the videos and now all of the videos which I have commited are "free to use" (from video description on youtube) |
OpenSourceSimon
requested changes
Nov 15, 2022
Deleted for backgrounds.json
Just took the new entries from the old `CONSTANTS.py` and moved them here (and changed the format so that it works!)
(Removed something that was commented out (in python)
Hi, my bad for not doing that it should be sorted now. |
OpenSourceSimon
approved these changes
Nov 17, 2022
|
Looks good to me as well, I will merge tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added:
as options for background gameplay
Issue Fixes
None
Checklist:
Any other information (e.g how to test the changes)
You can try setting the background video to