Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an install script #856

Merged
merged 18 commits into from
Jul 9, 2022
Merged

Add an install script #856

merged 18 commits into from
Jul 9, 2022

Conversation

micziz
Copy link
Contributor

@micziz micziz commented Jul 5, 2022

Description

This Pull Request adds 2 things.

Adds an install script. This is a continuation of #465.

Issue Fixes

Resolves this comment in #419 by @drugsosos "I can write install.sh for linux with all dependences and stuff"

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

None

@JasonLovesDoggo
Copy link
Collaborator

Sox should not be in the requirements.txt file

Copy link
Collaborator

@JasonLovesDoggo JasonLovesDoggo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@micziz
Copy link
Contributor Author

micziz commented Jul 6, 2022

The install instructions does not mention sox. Is It needed?

dependabot bot and others added 4 commits July 6, 2022 10:58
Bumps [boto3](https://github.com/boto/boto3) from 1.24.12 to 1.24.23.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.12...1.24.23)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [botocore](https://github.com/boto/botocore) from 1.27.22 to 1.27.23.
- [Release notes](https://github.com/boto/botocore/releases)
- [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst)
- [Commits](boto/botocore@1.27.22...1.27.23)

---
updated-dependencies:
- dependency-name: botocore
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@JasonLovesDoggo
Copy link
Collaborator

After much work me and Callum have managed to bypass it (Callum discovered athat we can use moviepy and implement it manually)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.23 to 1.24.24.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.23...1.24.24)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@micziz
Copy link
Contributor Author

micziz commented Jul 7, 2022

Ok, will remove

@micziz micziz changed the title Add an install script and add sox to requirements.txt Add an install script Jul 7, 2022
JasonLovesDoggo and others added 3 commits July 7, 2022 13:27
Bumps [botocore](https://github.com/boto/botocore) from 1.27.23 to 1.27.24.
- [Release notes](https://github.com/boto/botocore/releases)
- [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst)
- [Commits](boto/botocore@1.27.23...1.27.24)

---
updated-dependencies:
- dependency-name: botocore
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Collaborator

@callumio callumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good - I know of a Github issue for people trying to playwright install-deps on Arch that I'll try find, that can be linked somewhere

README.md Outdated Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@callumio callumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@callumio callumio merged commit 6808345 into elebumm:develop Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants