-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an install script #856
Conversation
Sox should not be in the requirements.txt file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
The install instructions does not mention sox. Is It needed? |
Bumps [boto3](https://github.com/boto/boto3) from 1.24.12 to 1.24.23. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.12...1.24.23) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bump boto3 from 1.24.12 to 1.24.23
Bumps [botocore](https://github.com/boto/botocore) from 1.27.22 to 1.27.23. - [Release notes](https://github.com/boto/botocore/releases) - [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst) - [Commits](boto/botocore@1.27.22...1.27.23) --- updated-dependencies: - dependency-name: botocore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bump botocore from 1.27.22 to 1.27.23
After much work me and Callum have managed to bypass it (Callum discovered athat we can use moviepy and implement it manually) |
Bumps [boto3](https://github.com/boto/boto3) from 1.24.23 to 1.24.24. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.23...1.24.24) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Ok, will remove |
Bump boto3 from 1.24.23 to 1.24.24
Bumps [botocore](https://github.com/boto/botocore) from 1.27.23 to 1.27.24. - [Release notes](https://github.com/boto/botocore/releases) - [Changelog](https://github.com/boto/botocore/blob/develop/CHANGELOG.rst) - [Commits](boto/botocore@1.27.23...1.27.24) --- updated-dependencies: - dependency-name: botocore dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bump botocore from 1.27.23 to 1.27.24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, looks good - I know of a Github issue for people trying to playwright install-deps on Arch that I'll try find, that can be linked somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Description
This Pull Request adds 2 things.
Adds an install script. This is a continuation of #465.
Issue Fixes
Resolves this comment in #419 by @drugsosos "I can write install.sh for linux with all dependences and stuff"
Checklist:
Any other information (e.g how to test the changes)
None