Fix: gracefully handle shorthashes longer than 7 characters (fixes #15) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumazure
approved these changes
Apr 24, 2017
btmills
approved these changes
Apr 24, 2017
gyandeeps
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the changelog generator to gracefully handle commit hashes longer than 7 characters. Long shorthashes like this can be produced by newer versions of git when working with a large repository. Previously, the release tool would skip any commits with long hashes (resulting in an empty changelog).
With this implementation, the long shorthashes will be included in the changelog rather than being truncated. One disadvantage of doing it this way is that the changelog might be inconsistent -- it could vary between 7-character and 8-character shorthashes depending on the version of git installed on the release machine. However, this does reduce the risk of generating broken links due to ambiguous commit hashes, which is the whole point of having longer shorthashes anyway.
Fixes #15