Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Update scripts for release (fixes #475) #478

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 16, 2021

  1. Split updating of lib/version.js into a separate script and created update-version npm script
  2. Renamed rollup script to build to be a bit more conventional
  3. Added a pretest script to run build before npm test
  4. Added a prepublishOnly script to run update-version and then build before npm publish

I believe this should take care of any of our remaining issues with the release process. We should, of course, run an alpha release first to verify. I tested this locally and everything seemed to work.

@nzakas nzakas requested a review from a team April 16, 2021 18:28
Copy link
Member

@btmills btmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally as well, and it worked correctly as far as I could tell.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left a comment about ci.yml.

"rollup": "rollup -c rollup.config.js",
"build": "rollup -c rollup.config.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update ci.yml, it uses npm run rollup.

@nzakas
Copy link
Member Author

nzakas commented Apr 19, 2021

@mdjermanovic nice catch. Updated.

@mdjermanovic mdjermanovic linked an issue Apr 19, 2021 that may be closed by this pull request
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdjermanovic mdjermanovic merged commit 8209e4e into main Apr 19, 2021
@mdjermanovic mdjermanovic deleted the script-updates branch April 19, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

espree v8 release process
4 participants