Custom domain simplifaction #163
Conversation
| @@ -243,6 +243,16 @@ def cname_to_github_user_domain? | |||
| cname? && !cname_to_pages_dot_github_dot_com? && cname.pages_domain? | |||
| end | |||
|
|
|||
| # Check if the CNAME points to a Domain that points to pages | |||
| # e.g. CNAME -> Domain -> Pages | |||
| def cname_to_domain_to_pages? | |||
There was a problem hiding this comment.
this function seems not check the cname point to A record which points to pages.
Does this allow the user input arbitrary cname?
There was a problem hiding this comment.
It should the main thing is that we are checking for is that the CNAME doesn't already point to us then we run this check
I have a test that checks if it points to it but let me add a test in the event that it doesn't
There was a problem hiding this comment.
I mainly mean if we want to only support www.fontawesome.it => fontawesome.it => pagesxxx
or loosely support blog.fontawesome.it => fontawesome.it => pagesxxxx
hmmm loosely is fine?
There was a problem hiding this comment.
ohh I see let me double check on that!
There was a problem hiding this comment.
So it looks like we just want to support www.fontawesome.it => fontawesome.it => pages where we match the host after the www
|
version file need to be changed if this need consume somewhere. |
| @@ -410,6 +410,8 @@ def cname | |||
| cnames = dns.take_while { |answer| answer.type == Dnsruby::Types::CNAME } | |||
| return if cnames.empty? | |||
|
|
|||
| # check to see if the CNAME starts with www | |||
| @wwwcname ||= cnames.last.name.to_s.start_with?("www") | |||
There was a problem hiding this comment.
I think we might want this to be www. so we don't match on wwwblog.cname.com?
| @wwwcname ||= cnames.last.name.to_s.start_with?("www") | |
| @wwwcname ||= cnames.last.name.to_s.start_with?("www.") |
closes: https://github.com/github/pages-engineering/issues/4205
Relaxes the validation process for
CNAMEby checking if the domain it points to points to GitHub Pages. This is done by creating a new method which checks if there is a record of typeAin the DNS to which theCNAMEpoints to. If this is the case then we just check if that points to Pages.