New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Dart imports #8380

Open

insertjokehere wants to merge 3 commits into google:master from insertjokehere:8379-dart-recursive-imports

Contributor

insertjokehere commented Aug 20, 2024

Fixes #7609
Fixes #8379

This PR builds on the work from #8259 to:

Add a simple test to catch regressions in this area
Fix an issue where include chains (a includes b which includes c) are naively represented as a single import in Dart, which doesn't reflect how Dart handles imports. I've adjusted the Dart code generator to include an export statement to match import statements for files in the same namespace to ensure that include chains work in the generated code

fawdlstty and others added 3 commits

August 20, 2024 10:11


          [dart] fix bug which generated wrong code

92842b2


          add rename_namespace declare

1eb693c


          Export all imported files in the same namespace to support recursive …

e78884b

…imports

github-actions bot added c++ codegen dart labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ codegen dart