Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update puppeteer #2507

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Update puppeteer #2507

merged 3 commits into from
Aug 15, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Aug 14, 2024 •
edited
Loading

Replaces #2506

There were breaking changes that needed to be fixed. Never change JavaScript.

amcasey
amcasey approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little suspicious that this might not be the most correct fix, but it's a test asset...

docker-compose.yml Show resolved Hide resolved
testassets/InteropTestsGrpcWebWebsite/Tests/custom-environment.js Show resolved Hide resolved
@JamesNK JamesNK merged commit 74ee5f0 into grpc:master Aug 15, 2024
4 of 5 checks passed
@JamesNK JamesNK deleted the jamesnk/update-jester branch August 15, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey approved these changes

@mgravell mgravell Awaiting requested review from mgravell

@ReubenBond ReubenBond Awaiting requested review from ReubenBond

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @amcasey