Add the option to use background and threshold options on trim #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there some way I could help or further things along to get this merged? |
|
Sorry for the latency here. Ping me if I do not answer a PR in a few days. |
greut
reviewed
Nov 23, 2017
| err := C.vips_find_trim_bridge(image, | ||
| &top, &left, &width, &height, | ||
| C.double(background.R), C.double(background.G), C.double(background.B), | ||
| C.double(threshold)) |
There was a problem hiding this comment.
Oh no! You're right. Should be float64 here, it's used as a double in libvips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trim function in libvips accepts optional parameters Background and Threshold, which can be quite important when trimming an image. The background is used to choose the color to actually trim away, and threshold is the amount of difference allowed, see here
This should add those parameters, directly from the Options struct just as other such parameters.
One extra thing to add would be to have an option to detect the color to be used from ie. the top left pixel, to work with previously unknown images. This is also a feature I need.