Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak WABT again by using main instead of a commit #6614

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

steven-johnson
Copy link
Contributor

Commit 09c40635207d42dd30ffaca22477fd3491dd9e7d is no longer being recognized for WABT; rather than whack-a-mole, let's just use main temporarily (I've requested the WABT team make a new tag ASAP so we can standardize on the new API)

@alexreinking
Copy link
Member

Ugh, who force-pushes to main/master?!

Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wish this were a cache variable, but I guess this is just a sharp edge no matter what until WABT tags a release

@steven-johnson steven-johnson merged commit ba86c2e into master Feb 15, 2022
@steven-johnson steven-johnson deleted the srj/wabt branch February 15, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants