Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float16 under asan, attempt #2 #7691

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fix float16 under asan, attempt #2 #7691

merged 2 commits into from
Jul 19, 2023

Conversation

steven-johnson
Copy link
Contributor

Some sneakiness going on.

Some sneakiness going on.
#else

// We haven't tested this variant, so emit a warning if we ever compile for it.
#pragma message "Support for Generator build() methods has been removed in Halide version 15."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this message right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooops

@steven-johnson steven-johnson merged commit 475b774 into main Jul 19, 2023
3 checks passed
@steven-johnson steven-johnson deleted the srj/f16-fix-take-2 branch July 19, 2023 19:13
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
* Fix float16 under asan, attempt halide#2

Some sneakiness going on.

* Update float16_t.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants