Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an erorr if split is called with the same older and inner var name #7715

Merged
merged 7 commits into from
Jul 27, 2023

Conversation

TH3CHARLie
Copy link
Contributor

fixes #7714

@TH3CHARLie TH3CHARLie changed the title Throw an erorr if split is called with the same older and inner name Throw an erorr if split is called with the same older and inner var name Jul 26, 2023
src/Func.cpp Outdated Show resolved Hide resolved
@TH3CHARLie TH3CHARLie requested a review from abadams July 26, 2023 20:47
src/Func.cpp Outdated Show resolved Hide resolved
@steven-johnson
Copy link
Contributor

We should probably add something in test/error to verify this stays fixed

@abadams abadams merged commit df4c981 into halide:main Jul 27, 2023
3 checks passed
@TH3CHARLie TH3CHARLie deleted the xuanda/fix-7714 branch July 27, 2023 16:36
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
…ame (halide#7715)

* throw an erorr if split is called with the same older and inner name

* update

* fix naming

* rewording

* add test

---------

Co-authored-by: Steven Johnson <srj@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A split can use the same var name for inner and outer without error
3 participants