Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp: Fix Isochronous transfers #1690

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

tore-espressif
Copy link
Contributor

@tore-espressif tore-espressif commented Oct 18, 2022

On ESP32-S2/S3 ISO IN packets must be configured for even or odd frame. If they're not, they are transmitted only in even frames, so every second packet is lost.

Closes #1382

Describe the PR
Fix Isochronous IN transfers on Espressif's SoCs.

cc @kaspernyhus @leeebo

On ESP32-S2/S3 ISO transfers must be configured for even or odd frame.

Closes hathach#1382
@tore-espressif
Copy link
Contributor Author

cc @me-no-dev

@PanRe
Copy link
Collaborator

PanRe commented Oct 18, 2022

@hathach I would vote to merge the PR, you are good with that?

@PanRe PanRe mentioned this pull request Oct 18, 2022
@leeebo
Copy link

leeebo commented Oct 19, 2022

The bugfix works for me, no frame is missed now.

iso_bug_fixed

@PanRe
Copy link
Collaborator

PanRe commented Oct 20, 2022

@leebo Could you test if there is a potential bug? If so, could you please open a new issue therefore? Many thanks in advance!

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much for the fix. This is indeed out of my knowledge, we may also need to update the dwc2 as well to adopt this fix. Thank you @PanRe for reviewing and @leeebo for testing this out.

@hathach hathach merged commit bfcdef4 into hathach:master Oct 21, 2022
@leeebo
Copy link

leeebo commented Oct 24, 2022

@PanRe The dwc2 port has handled this condition here, I'll test again to make sure.

@tore-espressif tore-espressif deleted the fix/espressif/iso_transfers branch October 24, 2022 05:01
@leeebo
Copy link

leeebo commented Oct 25, 2022

@PanRe It works fine when using dwc2 driver for esp32s2/s3, no packet missed.

截图 2022-10-25 19-36-06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing iso packets in audio_test
4 participants