Use a trait for the common Virtq interface #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagatay-y
force-pushed
the
virtqueue-trait
branch
2 times, most recently
from
e6c6219
to
10b7838
Compare
Use a trait instead of a wrapper enum to represent the interface provided by both SplitVq and PackedVq.
The BufferToken attached to VirtqError::WriteTooLarge was not used and increased the error size from 16 bytes to 184 bytes. The enum was large also earlier (176 bytes), but the last commit made it exceed clippy's threshold.
Move method docs to trait definition and remove references to methods that were removed.
cagatay-y
force-pushed
the
virtqueue-trait
branch
from
10b7838
to
ecbedf1
Compare
prep_buffer and prep_transfer_from_raw are implemented the exact same way for SplitVq and PackedVq. This commit merges them into default implementations inside the trait.
|
a0c1b5a is a bit outside the scope of the PR but I pushed it into this branch rather than making it a separate PR because it depends on the older commits. If preferred, we can merge only the commits before it and I can open it as a separate PR. |
|
FYI: |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial version simply comments out a method that would be more difficult to adapt, as I wanted to see if the rest works on CI before dealing with it. Should also solve #989 (by removing the need for it).