Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stabilize kernel interface #1167

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

stlankes
Copy link
Contributor

@stlankes stlankes commented May 2, 2024

In case, that POSIX provides similar system calls, HermitOS uses variants of these system calls. These similiarties should increase the readability of the interface.

See also hermit-os/hermit-rs#570

Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, aside from a few remarks. 👍

src/syscalls/socket.rs Outdated Show resolved Hide resolved
src/syscalls/socket.rs Outdated Show resolved Hide resolved
src/syscalls/socket.rs Outdated Show resolved Hide resolved
src/time.rs Outdated Show resolved Hide resolved
src/time.rs Outdated Show resolved Hide resolved
In case, that POSIX provides similiar system calls, HermitOS
uses variants of these system calls. These similiarties should
increase the readability of the interface.
@mkroening mkroening changed the title stablize interface to kernel feat: stabilize kernel interface May 6, 2024
@mkroening mkroening enabled auto-merge May 6, 2024 13:43
@mkroening mkroening added this pull request to the merge queue May 6, 2024
Merged via the queue into hermit-os:main with commit 25fb095 May 6, 2024
13 checks passed
@mkroening mkroening deleted the stabelized branch May 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants