Fix locking/unlocking transition state in Matter lock platform

[marcelveldt]

Proposed change

There was an incorrect assumption in the implementation of the Matter lock platform that the state 'NotFullyLocked' was to indicate the lock is transitioning to the next state but that is not true.

The specification says:

The Not Fully Locked value is used by a lock to indicate that the state of the lock is somewhere between Locked and Unlocked so it is only partially secured. For example, a deadbolt could be par­tially extended and not in a dead latched state.

In fact a lock may use this state (value 0) to indicate the lock is unlocked, as reported for at least SwitchBot in #120694 so the whole code was wrong. Fixed the code to treat NotFullyLocked as unlocked and use optimistic state for locking/unlocking instead (reset as soon as a state change comes in).

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Switchbot Lock Pro recognize, functional but status is always UNKNOWN #120694
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[edenhaus]

Thanks @marcelveldt 👍

[MartinHjelmare]

Should we use _attr_is_opening?

[marcelveldt]

Do we have that?

[MartinHjelmare]

core/homeassistant/components/lock/__init__.py

Lines 213 to 216 in c3830a5

	@cached_property
	def is_opening(self) -> bool | None:
	"""Return true if the lock is opening."""
	return self._attr_is_opening

core/homeassistant/components/lock/__init__.py

Lines 272 to 279 in c3830a5

	@final
	@property
	def state(self) -> str | None:
	"""Return the state."""
	if self.is_jammed:
	return STATE_JAMMED
	if self.is_opening:
	return STATE_OPENING

https://developers.home-assistant.io/docs/core/entity/lock#properties