Fix reauth error and exception in ista EcoTrend integration #121482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This fixes a problem were the integration initiates a reauth flow every few days. The library handles expiration of the authorization token, but does not handle expiration of the refresh token properly. Although a login is quite costly as it requires several requests, the integrations interval is 24h, so it is justifiable to initiate a re-login on every coordinator update.
This also fixes an error in the translation placeholder were the email account property of the library is accessed that is no longer available since the last dependency update. Instead the value is now retrieved from the config entry.
Could this fix be considered next HA patch version 2024.7.3
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: