Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reauth error and exception in ista EcoTrend integration #121482

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Jul 8, 2024

Proposed change

This fixes a problem were the integration initiates a reauth flow every few days. The library handles expiration of the authorization token, but does not handle expiration of the refresh token properly. Although a login is quite costly as it requires several requests, the integrations interval is 24h, so it is justifiable to initiate a re-login on every coordinator update.

This also fixes an error in the translation placeholder were the email account property of the library is accessed that is no longer available since the last dependency update. Instead the value is now retrieved from the config entry.

Could this fix be considered next HA patch version 2024.7.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 11, 2024 13:29
@tr4nt0r tr4nt0r marked this pull request as ready for review July 11, 2024 14:47
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 19, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tr4nt0r 👍

../Frenck

@frenck frenck merged commit 3ddcffb into home-assistant:dev Jul 19, 2024
26 checks passed
@frenck frenck mentioned this pull request Jul 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cherry-picked cla-signed integration: ista_ecotrend Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ista EcoTrend keeps asking for re-authentication
3 participants