Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct type annotation for EntityPlatform.async_register_entity_service #123054

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Aug 2, 2024

Proposed change

Correct type annotation for EntityPlatform.async_register_entity_service; it doesn't handle a None schema passed to it

This partially reverts changes from PR #120475

Needs #123060

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should this be included in the beta as well, just in case custom integrations use it for type checking?

@emontnemery emontnemery added this to the 2024.8.0 milestone Aug 2, 2024
@emontnemery
Copy link
Contributor Author

Looks good. Should this be included in the beta as well, just in case custom integrations use it for type checking?

Yes, I think that makes sense 👍

As discussed on Discord, I think it makes sense to actually allow passing a None schema, I think we should look into that.

@emontnemery emontnemery merged commit 449afe9 into dev Aug 2, 2024
35 checks passed
@emontnemery emontnemery deleted the entity_schema_correct_type branch August 2, 2024 09:58
frenck pushed a commit that referenced this pull request Aug 2, 2024
…vice` (#123054)

Correct type annotation for EntityPlatform.async_register_entity_service

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants