Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioruckus to v0.41 removing blocking call to load_default_certs from ruckus_unleashed integration #123974

Merged

Conversation

ms264556
Copy link
Contributor

@ms264556 ms264556 commented Aug 15, 2024

Proposed change

Update aioruckus dependency to newer version which doesn't have a blocking call to load_default_certs.

Note:
This aioruckus update includes a significant amount of additional functionality, in addition to the load_default_certs fix.
There is new Unleashed functionality, some typing, plus initial SmartZone and R1 support.

ms264556/aioruckus@v0.34...v0.41

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @lanrat, @gabe565, mind taking a look at this pull request as it has been labeled with an integration (ruckus_unleashed) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ruckus_unleashed can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ruckus_unleashed Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@lanrat lanrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allenporter allenporter changed the title Remove blocking call to load_default_certs from ruckus_unleashed integration Bump aioruckus to v0.30 removing blocking call to load_default_certs from ruckus_unleashed integration Aug 25, 2024
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff of the upstream library and it looks good. I have a question about the loggers change.

homeassistant/components/ruckus_unleashed/manifest.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 25, 2024 14:45
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@ms264556 ms264556 changed the title Bump aioruckus to v0.30 removing blocking call to load_default_certs from ruckus_unleashed integration Bump aioruckus to v0.41 removing blocking call to load_default_certs from ruckus_unleashed integration Aug 30, 2024
@ms264556 ms264556 marked this pull request as ready for review August 30, 2024 01:44
@allenporter allenporter merged commit 4dfc11a into home-assistant:dev Aug 30, 2024
40 checks passed
@bdraco bdraco added this to the 2024.9.0 milestone Aug 30, 2024
@bdraco
Copy link
Member

bdraco commented Aug 30, 2024

Tagged for beta since this fixes blocking I/O in the event loop and a warning

bramkragten pushed a commit that referenced this pull request Aug 30, 2024
…from ruckus_unleashed integration (#123974)

* fix ruckusd_unleashed blocking call to load_default_certs

* remove extra loggers, bump aioruckus ver for debian packagers
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
@ms264556 ms264556 deleted the bugfix/ruckus_unleashed_blocking_call branch September 10, 2024 03:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruckus_unleashed: Detected blocking call to load_default_certs
5 participants