-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aioruckus to v0.41 removing blocking call to load_default_certs from ruckus_unleashed integration #123974
Bump aioruckus to v0.41 removing blocking call to load_default_certs from ruckus_unleashed integration #123974
Conversation
Hey there @lanrat, @gabe565, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the diff of the upstream library and it looks good. I have a question about the loggers change.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Tagged for beta since this fixes blocking I/O in the event loop and a warning |
…from ruckus_unleashed integration (#123974) * fix ruckusd_unleashed blocking call to load_default_certs * remove extra loggers, bump aioruckus ver for debian packagers
Proposed change
Update
aioruckus
dependency to newer version which doesn't have a blocking call to load_default_certs.Note:
This
aioruckus
update includes a significant amount of additional functionality, in addition to the load_default_certs fix.There is new Unleashed functionality, some typing, plus initial SmartZone and R1 support.
ms264556/aioruckus@v0.34...v0.41
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: