Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yalexs to 8.1.2 #124303

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Bump yalexs to 8.1.2 #124303

merged 4 commits into from
Aug 20, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 20, 2024

Proposed change

changelog: bdraco/yalexs@v8.0.2...v8.1.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco bdraco changed the title Bump yalexs to 8.1.0 Bump yalexs to 8.1.1 Aug 20, 2024
@joostlek joostlek closed this Aug 20, 2024
@joostlek joostlek reopened this Aug 20, 2024
@bdraco
Copy link
Member Author

bdraco commented Aug 20, 2024

thanks

@bdraco bdraco closed this Aug 20, 2024
@bdraco bdraco reopened this Aug 20, 2024
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@home-assistant home-assistant bot marked this pull request as draft August 20, 2024 15:11
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@bdraco
Copy link
Member Author

bdraco commented Aug 20, 2024

Will need to fix that in the lib and do another release to make it back compat

@bdraco
Copy link
Member Author

bdraco commented Aug 20, 2024

Too many branches and too many brands. Unfortunately we have to keep back compat so I do have to change the lib

@bdraco
Copy link
Member Author

bdraco commented Aug 20, 2024

So unfortunate that august can't switch to oauth as well ...

@bdraco bdraco changed the title Bump yalexs to 8.1.1 Bump yalexs to 8.1.2 Aug 20, 2024
@bdraco
Copy link
Member Author

bdraco commented Aug 20, 2024

Its not as clean as I would have liked but I can clean it up once we merge #123806 back to dev and than I can do a major release of yalexs to make a breaking change to reduce it

@bdraco bdraco marked this pull request as ready for review August 20, 2024 15:57
@home-assistant home-assistant bot requested a review from joostlek August 20, 2024 15:57
@bdraco
Copy link
Member Author

bdraco commented Aug 20, 2024

thanks

@bdraco bdraco merged commit ce82c79 into dev Aug 20, 2024
40 checks passed
@bdraco bdraco deleted the yalexs_810 branch August 20, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
@bdraco bdraco modified the milestone: 2024.8.3 Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants