-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #122676 Yamaha discovery #125216
Revert #122676 Yamaha discovery #125216
Conversation
@pssc I discussed the problem with some people from the core team and we think this is the better step instead of overengineering a storage and thing. Also, we can use a flow similar to |
Tested OK by @tomlut |
Thanks for the feedback @joostlek understood lets get people working again. |
This PR was meant for 2024.9, but didn't make it. Can we look into config flow for 2024.10? |
Did I ask if you have discord yet? |
Yes sporadically seems to be a number of months since I logged in. |
We can discuss on there if you want |
Confirmed, 2024.9.1 no longer breaks my Yamaha. Thanks! |
Revert Yamaha discovery
Proposed change
Revert Yamaha discovery since a lot of users have trouble with the discovery, causing stability issues. This PR reverts #122676. Instead, we should follow up with migrating to the config flow, where we can use the SSDP methods from Home Assistant, which are way more robust.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: