Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #122676 Yamaha discovery #125216

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Sep 4, 2024

Proposed change

Revert Yamaha discovery since a lot of users have trouble with the discovery, causing stability issues. This PR reverts #122676. Instead, we should follow up with migrating to the config flow, where we can use the SSDP methods from Home Assistant, which are way more robust.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member Author

joostlek commented Sep 4, 2024

@pssc I discussed the problem with some people from the core team and we think this is the better step instead of overengineering a storage and thing. Also, we can use a flow similar to reolink or dlink to link a DHCP mesasge to a succesfully loaded intergation, allowing us to set the unique_id for manual setup or imported configurations

@joostlek joostlek added this to the 2024.9.0 milestone Sep 4, 2024
@joostlek joostlek changed the title Revert Yamaha discovery Revert #122676 Yamaha discovery Sep 4, 2024
@joostlek
Copy link
Member Author

joostlek commented Sep 4, 2024

Tested OK by @tomlut

@joostlek joostlek marked this pull request as ready for review September 4, 2024 13:14
@bramkragten bramkragten modified the milestones: 2024.9.0, 2024.9.1 Sep 4, 2024
@pssc
Copy link
Contributor

pssc commented Sep 4, 2024

@pssc I discussed the problem with some people from the core team and we think this is the better step instead of overengineering a storage and thing. Also, we can use a flow similar to reolink or dlink to link a DHCP mesasge to a succesfully loaded intergation, allowing us to set the unique_id for manual setup or imported configurations

Thanks for the feedback @joostlek understood lets get people working again.

@joostlek
Copy link
Member Author

joostlek commented Sep 4, 2024

This PR was meant for 2024.9, but didn't make it. Can we look into config flow for 2024.10?

@pssc
Copy link
Contributor

pssc commented Sep 5, 2024

fixes #123861 #124087 #124012

@joostlek
Copy link
Member Author

joostlek commented Sep 5, 2024

Did I ask if you have discord yet?

@pssc
Copy link
Contributor

pssc commented Sep 5, 2024

Did I ask if you have discord yet?

Yes sporadically seems to be a number of months since I logged in.

@joostlek
Copy link
Member Author

joostlek commented Sep 5, 2024

We can discuss on there if you want

@balloob balloob merged commit 1e6b6fe into home-assistant:dev Sep 6, 2024
28 checks passed
balloob pushed a commit that referenced this pull request Sep 6, 2024
@balloob balloob mentioned this pull request Sep 6, 2024
@avwuff
Copy link

avwuff commented Sep 7, 2024

Confirmed, 2024.9.1 no longer breaks my Yamaha. Thanks!

Gigatrappeur pushed a commit to Gigatrappeur/ha-core that referenced this pull request Sep 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants