-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Hue sending effect None at turn_on command while no effect is active #125377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: hue
small-pr
PRs with less than 30 lines.
labels
Sep 5, 2024
Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
balloob
approved these changes
Sep 5, 2024
joostlek
approved these changes
Sep 6, 2024
balloob
pushed a commit
that referenced
this pull request
Sep 6, 2024
… active (#125377) * Fix for Hue sending effect None at turn_on command while no effect is active * typo * update tests
Merged
Gigatrappeur
pushed a commit
to Gigatrappeur/ha-core
that referenced
this pull request
Sep 7, 2024
… active (home-assistant#125377) * Fix for Hue sending effect None at turn_on command while no effect is active * typo * update tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cherry-picked
cla-signed
integration: hue
Quality Scale: platinum
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix a tiny (but annoying) bug that is introduced after a recent Hue Bridge update.
You can send a special "no effect" effect value to a light to make it stop its active effect but if you send that while no effect is active, it can cause weird behavior or the command might fail entirely.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: