Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at adding the ability to dynamically addHost(host,target) and removeHost(host) to the ProxyTable #195

Closed
wants to merge 2 commits into from

Conversation

tglines
Copy link

@tglines tglines commented Feb 12, 2012

I think it needs more tests/validation that I didn't mess something else up here, but it's a first stab at it.

@tglines
Copy link
Author

tglines commented Feb 12, 2012

Adresses:

#111
#126
#60

@tglines
Copy link
Author

tglines commented Feb 12, 2012

I think it also needs a conditional for determining if it's a routing proxy or http proxy ... I'll wait for some feedback.

@indexzero
Copy link
Contributor

lgtm. I'll try to get this merged in this week.

@AndreasMadsen
Copy link

@indexzero could we get an update on this?

@tglines
Copy link
Author

tglines commented Mar 4, 2012

@indexzero @Marak hearing crickets here ...

@indexzero
Copy link
Contributor

Sorry. Backlog of other work. I'll try to review this week, but Nodejitsu core is taking up the lion's share of the team's time.

@devrim
Copy link

devrim commented Mar 9, 2012

this would be pretty sweet - we will then replace all our nginx frontend with node-http-proxy

@dudemeister
Copy link

this would be awesome! we're currently moving from apache proxying to node-http-proxy and we'll be including this on our version...

@tglines
Copy link
Author

tglines commented Apr 2, 2012

Wanted to let everyone here know of a method that works just fine since nodejitsu didn't talke the pull request.

You can pass a string through into options.router that's a path to a file that has the routes as json. The process then watches this file for changes and updates the routing. Basically you can achieve the same effect I was trying to achieve with this pull by having a process that edits that file.

Routing file (router.json):

{
    "router": {
        "nodejitsu.com/doesnt-take-pull-reqs": "127.0.0.1:5000"
    }
}

Options passed

var options = {
    router: "./router.json"
};

@tglines tglines closed this Apr 2, 2012
indexzero added a commit that referenced this pull request Mar 9, 2013
…ted. Update tests to use new macros. Fixes #195. Fixes #60.
@indexzero indexzero mentioned this pull request Mar 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants